removed WHATEVER(1) ˌhwʌˈtɛvɚ from scripts/tts_dataset_files/ipa_cmudict-0.7b_nv22.10.txt #5869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blisc
reviewed
Jan 27, 2023
blisc
reviewed
Jan 27, 2023
redoctopus
reviewed
Jan 27, 2023
|
Can you rename scripts/tts_dataset_files/ipa_cmudict-0.7b_nv22.10.txt to scripts/tts_dataset_files/ipa_cmudict-0.7b_nv23.01.txt instead of creating a new file? |
blisc
reviewed
Feb 7, 2023
blisc
previously approved these changes
Feb 9, 2023
Signed-off-by: MikyasDesta <[email protected]>
Signed-off-by: MikyasDesta <[email protected]>
Signed-off-by: MikyasDesta <[email protected]>
Signed-off-by: MikyasDesta <[email protected]>
Signed-off-by: MikyasDesta <[email protected]>
MikyasDesta
force-pushed
the
ipa_g2p_minor_fix
branch
from
031bac8
to
38b736e
Compare
blisc
approved these changes
Feb 10, 2023
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
…ict-0.7b_nv22.10.txt (NVIDIA#5869) * removed WHATEVER(1) ˌhwʌˈtɛvɚ Signed-off-by: MikyasDesta <[email protected]> * remove WHATEVER(1) and WHATEVER's(1) Signed-off-by: MikyasDesta <[email protected]> * removed nv22.10.txt Signed-off-by: MikyasDesta <[email protected]> * added updated and removed words to notes Signed-off-by: MikyasDesta <[email protected]> * sign off Signed-off-by: MikyasDesta <[email protected]> --------- Signed-off-by: MikyasDesta <[email protected]> Co-authored-by: Mikyas Desta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
changed WHATEVER ˌwʌˈtɛvɚ to WHATEVER ˌwʌtˈɛvɚ and deleted WHATEVER(1)
updated WHATEVER'S to ˌwʌtˈɛvɚz and delete WHATEVER'S(1).
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information