Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make validation accuracy reporting optional for adapters/ptuning #5843

Merged
merged 27 commits into from
Feb 13, 2023

Conversation

arendu
Copy link
Collaborator

@arendu arendu commented Jan 24, 2023

What does this PR do ?

accuracy reporting is ~10-20x slower for prompt learning and adapter learning for t5. This PR optionally disables it.

Collection: [NLP]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Feb 7, 2023
@arendu arendu marked this pull request as ready for review February 8, 2023 18:50
@arendu arendu requested a review from Davood-M February 8, 2023 18:50
Signed-off-by: arendu <[email protected]>
@github-actions github-actions bot removed the stale label Feb 9, 2023
Copy link
Collaborator

@Davood-M Davood-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🙏🏻

@Davood-M Davood-M merged commit 99652c7 into main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants