Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container info to main page #5816

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Add container info to main page #5816

merged 3 commits into from
Jan 18, 2023

Conversation

fayejf
Copy link
Collaborator

@fayejf fayejf commented Jan 18, 2023

What does this PR do ?

Add container in for to main page

Collection: core

Changelog

  • Add built container info to main readme for better visibility.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: fayejf <[email protected]>
Signed-off-by: fayejf <[email protected]>
@fayejf fayejf marked this pull request as ready for review January 18, 2023 02:35
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

@titu1994 titu1994 merged commit f0b52b3 into main Jan 18, 2023
@titu1994 titu1994 deleted the add_container_mainpage branch January 18, 2023 03:34
Kipok pushed a commit to Kipok/NeMo that referenced this pull request Jan 31, 2023
* add container info to main page

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

Signed-off-by: fayejf <[email protected]>
ericharper pushed a commit that referenced this pull request Jan 31, 2023
* add container info to main page

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

Signed-off-by: fayejf <[email protected]>
ericharper pushed a commit that referenced this pull request Jan 31, 2023
* add container info to main page

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

Signed-off-by: fayejf <[email protected]>
Kipok pushed a commit to Kipok/NeMo that referenced this pull request Jan 31, 2023
* add container info to main page

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

Signed-off-by: fayejf <[email protected]>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Mar 24, 2023
* add container info to main page

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

* fix

Signed-off-by: fayejf <[email protected]>

Signed-off-by: fayejf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants