Don't print exp_manager warning when max_steps == -1 #5725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
previously approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Thanks for this fix, LGTM!
Would you mind signing off the commits? NeMo requires signed off commits, instructions are here: https://github.com/NVIDIA/NeMo/pull/5725/checks?check_run_id=10416255078
Signed-off-by: Alexandre Milesi <[email protected]>
|
Done! |
SeanNaren
approved these changes
Jan 3, 2023
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Alexandre Milesi <[email protected]> Signed-off-by: andrusenkoau <[email protected]>
erastorgueva-nv
pushed a commit
that referenced
this pull request
Jan 12, 2023
Signed-off-by: Alexandre Milesi <[email protected]> Signed-off-by: Elena Rastorgueva <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
Signed-off-by: Alexandre Milesi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Doesn't print a warning when max_steps == -1 and val monitoring. For example, when we just provide max_epochs we don't want to see that warning.
Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.