Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nested NeMo models #5671

Merged
merged 44 commits into from
Jan 23, 2023
Merged

Support nested NeMo models #5671

merged 44 commits into from
Jan 23, 2023

Commits on Dec 19, 2022

  1. Nested NeMo models support: save-restore with artifacts 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    21f9e79 View commit details
    Browse the repository at this point in the history

  2. Fix import 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    a830aee View commit details
    Browse the repository at this point in the history

  3. Improve tests 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    cd494d1 View commit details
    Browse the repository at this point in the history

  4. Add test for double nested model 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    a19197c View commit details
    Browse the repository at this point in the history

  5. Fix target for mock model with children 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    f8519a4 View commit details
    Browse the repository at this point in the history

  6. MockModel config: revert to original 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    3295d75 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Add comments. Clean up 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    b114920 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into support_nested_models

    @okuchaiev
    okuchaiev authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    7b661d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Add docstring. Test number of artifacts 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    b722181 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Merge branch 'main' into support_nested_models

    @artbataev
    artbataev authored Jan 9, 2023
    Configuration menu
    Copy the full SHA
    35ffb35 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Handle cases when child model can change config 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    f7d42f4 View commit details
    Browse the repository at this point in the history

  2. Add test for multiple test-restore passes 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    b8e0f82 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into support_nested_models

    @artbataev
    artbataev authored Jan 10, 2023
    Configuration menu
    Copy the full SHA
    47e5e89 View commit details
    Browse the repository at this point in the history

  4. Do not use artifacts from models not in config 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    3d5e13d View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Fix for the case when artifacts attribute is not assigned 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    49d2895 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2023

  1. Merge branch 'main' into support_nested_models

    @ericharper
    ericharper authored Jan 14, 2023
    Configuration menu
    Copy the full SHA
    f775a5d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Merge branch 'main' into support_nested_models

    @artbataev
    artbataev authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    10549cf View commit details
    Browse the repository at this point in the history

  2. Improve documentation. Clarify 2 cases for model construction. 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    7a5d83a View commit details
    Browse the repository at this point in the history

  3. Avoid unpacking duplicated restoration paths 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    0136793 View commit details
    Browse the repository at this point in the history

  4. Fix docs 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    2347400 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into support_nested_models

    @artbataev
    artbataev authored Jan 16, 2023
    Configuration menu
    Copy the full SHA
    40c5437 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Implement explicit submodule registration 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    b276cb9 View commit details
    Browse the repository at this point in the history

  2. Temporary fix pytorch-lightning 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    20067cb View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2023

  1. Merge branch 'main' into support_nested_models 

    # Conflicts:
#	requirements/requirements_lightning.txt
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    77bb11b View commit details
    Browse the repository at this point in the history

  2. Use stt_en_conformer_ctc_small for testing nested models + from_pretr… 

    …ained

Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    da7de90 View commit details
    Browse the repository at this point in the history

  3. Test different config path and attribute name 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    b5960d5 View commit details
    Browse the repository at this point in the history

  4. Explicitly disallow registering .nemo checkpoint file as an artifact.… 

    … Clean up

Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    7337fd1 View commit details
    Browse the repository at this point in the history

  5. Add todo 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    5581f18 View commit details
    Browse the repository at this point in the history

  6. Fix named_nemo_modules 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    f6f84aa View commit details
    Browse the repository at this point in the history

  7. Add documentation 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    d970b50 View commit details
    Browse the repository at this point in the history

  8. Revert disallowing .nemo model as an artifact 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    13ba08f View commit details
    Browse the repository at this point in the history

  9. Fix unused import 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 19, 2023
    Configuration menu
    Copy the full SHA
    96ffd43 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Disallow registering .nemo file as an artifact 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    75c9622 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    d498a26 View commit details
    Browse the repository at this point in the history

  3. Fix docs 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    07dc349 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'support_nested_models' of github.com:artbataev/NeMo int… 

    …o support_nested_models
    @artbataev
    artbataev committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    050a57c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into support_nested_models

    @artbataev
    artbataev authored Jan 20, 2023
    Configuration menu
    Copy the full SHA
    0cae024 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Merge branch 'main' into support_nested_models

    @artbataev
    artbataev authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    0589c33 View commit details
    Browse the repository at this point in the history

  2. Revert test for nested RNNT model, fix according to the new approach 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    764f76f View commit details
    Browse the repository at this point in the history

  3. Fix documentation 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    5bf9b0e View commit details
    Browse the repository at this point in the history

  4. Fix documentation 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    d929d3f View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into support_nested_models

    @artbataev
    artbataev authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    0e68a46 View commit details
    Browse the repository at this point in the history

  6. Fix documentation for register_nemo_submodule 

    Co-authored-by: Sean Naren <[email protected]>
Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev @SeanNaren
    artbataev and SeanNaren authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    80a6706 View commit details
    Browse the repository at this point in the history

  7. Protect inner nemo submodules mapping 

    Signed-off-by: Vladimir Bataev <[email protected]>
    @artbataev
    artbataev committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    eb6ec43 View commit details
    Browse the repository at this point in the history