TTS tutorial update: use speaker 9017 instead of 6097 #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jocelyn Huang <[email protected]>
ekmb
previously approved these changes
Dec 1, 2022
| @@ -326,7 +326,7 @@ | |||
| "`\n", | |||
There was a problem hiding this comment.
In general, it's better to use this whitelist: https://github.com/NVIDIA/NeMo/blob/main/nemo_text_processing/text_normalization/en/data/whitelist/tts.tsv , not needed for hi-fi tts as it's already normalized
There was a problem hiding this comment.
Should be a quick change. Would you prefer it in this PR or a new one?
There was a problem hiding this comment.
up to you. Some checks are still running - hmm, it's been 19+ hrs since the last commit
Signed-off-by: Jocelyn Huang <[email protected]>
Signed-off-by: Jocelyn Huang <[email protected]>
ekmb
approved these changes
Dec 1, 2022
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Dec 5, 2022
* TTS tutorial update: speaker 9017 instead of 6097 Signed-off-by: Jocelyn Huang <[email protected]> * Update whitelist path to tts.tsv Signed-off-by: Jocelyn Huang <[email protected]> * Add some info about getting pitch stats to TTS fine-tuning tutorial Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Dec 5, 2022
* TTS tutorial update: speaker 9017 instead of 6097 Signed-off-by: Jocelyn Huang <[email protected]> * Update whitelist path to tts.tsv Signed-off-by: Jocelyn Huang <[email protected]> * Add some info about getting pitch stats to TTS fine-tuning tutorial Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
* TTS tutorial update: speaker 9017 instead of 6097 Signed-off-by: Jocelyn Huang <[email protected]> * Update whitelist path to tts.tsv Signed-off-by: Jocelyn Huang <[email protected]> * Add some info about getting pitch stats to TTS fine-tuning tutorial Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: andrusenkoau <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* TTS tutorial update: speaker 9017 instead of 6097 Signed-off-by: Jocelyn Huang <[email protected]> * Update whitelist path to tts.tsv Signed-off-by: Jocelyn Huang <[email protected]> * Add some info about getting pitch stats to TTS fine-tuning tutorial Signed-off-by: Jocelyn Huang <[email protected]> Signed-off-by: Jocelyn Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jocelyn Huang [email protected]
What does this PR do ?
Replaces speaker 6097's data with speaker 9017's since the latter has given explicit permission.
Collection: TTS
Changelog
Usage