Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add speaker_tasks datasets folder, add diarization datasets voxconverse/aishell #5042

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Add speaker_tasks datasets folder, add diarization datasets voxconverse/aishell #5042

merged 5 commits into from
Oct 3, 2022

Conversation

SeanNaren
Copy link
Collaborator

@SeanNaren SeanNaren commented Sep 29, 2022 •
edited
Loading

What does this PR do ?

Adds a folder to store the speaker_tasks datasets. Few things to consider:

  • I could create a nested diarization folder to be more specific, but I thought just one folder would be fine
  • I might've missed some scripts that would be better suited to exist in this new folder

Changelog

  • Add speaker_tasks datasets folder, add diarization datasets voxconverse/aishell.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@SeanNaren SeanNaren self-assigned this Sep 29, 2022
nithinraok
nithinraok reviewed Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sean, can you also move hi-mia data to speaker_tasks

scripts/dataset_processing/speaker_tasks/get_voxconverse.py Outdated Show resolved Hide resolved
@SeanNaren
Address review
22309b5 
Signed-off-by: SeanNaren <[email protected]>
@SeanNaren
Copy link
Collaborator Author

@nithinraok could i get a re-review?

@nithinraok
Copy link
Collaborator

tutorials/speaker_tasks/Speaker_Identification_Verification.ipynb This notebook needs to be updated to use latest path of hi-mia. rest looks good to me.

@SeanNaren
Update link in notebook
83b7191 
Signed-off-by: SeanNaren <[email protected]>
@SeanNaren
Copy link
Collaborator Author

done @nithinraok!

@nithinraok
Copy link
Collaborator

Thanks Sean. LGTM

@SeanNaren SeanNaren merged commit 5ad11b9 into main Oct 3, 2022
@SeanNaren SeanNaren deleted the feat/speaker_tasks_datasets branch October 3, 2022 09:27
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Oct 6, 2022
@SeanNaren @titu1994
Add speaker_tasks datasets folder, add diarization datasets voxconv…
baa15d3 
…erse/aishell (NVIDIA#5042)

* Add speaker tasks folder, add diarization daatasets voxconverse/aishell

Signed-off-by: SeanNaren <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@SeanNaren
Add speaker_tasks datasets folder, add diarization datasets voxconv…
bc9dcf6 
…erse/aishell (NVIDIA#5042)

* Add speaker tasks folder, add diarization daatasets voxconverse/aishell

Signed-off-by: SeanNaren <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@SeanNaren
Add speaker_tasks datasets folder, add diarization datasets voxconv…
1eaf513 
…erse/aishell (NVIDIA#5042)

* Add speaker tasks folder, add diarization daatasets voxconverse/aishell

Signed-off-by: SeanNaren <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithinraok nithinraok nithinraok left review comments

@titu1994 titu1994 Awaiting requested review from titu1994

@tango4j tango4j Awaiting requested review from tango4j

Assignees

@SeanNaren SeanNaren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SeanNaren @nithinraok