Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorials.rst for question answering #4895

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

Zhilin123
Copy link
Collaborator

@Zhilin123 Zhilin123 commented Sep 7, 2022

What does this PR do ?

Documentation bug fix.

Collection: nlp

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue 4775)

Copy link
Contributor

@yzhang123 yzhang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Zhilin123 Zhilin123 merged commit 69381eb into main Sep 8, 2022
@Zhilin123 Zhilin123 deleted the fix_question_answering_docs branch September 8, 2022 00:20
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 3, 2022
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants