[Tutorial][ASR][Fix] Data paths in ASR with NeMo tutorial #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ante Jukić <[email protected]>
titu1994
approved these changes
Aug 31, 2022
| @@ -56,10 +56,6 @@ | |||
| "BRANCH = 'main'\n", | |||
| "!python -m pip install git+https://github.com/NVIDIA/NeMo.git@$BRANCH#egg=nemo_toolkit[all]\n", | |||
| "\n", | |||
| "## Grab the config we'll use in this example\n", | |||
| "!mkdir configs\n", | |||
There was a problem hiding this comment.
Why is this being moved ?
There was a problem hiding this comment.
Just convenience. The first cell is mostly about setting up environment in Colab, so I'd usually skip/comment it. However, this bit is necessary anyway, so I moved it to the spot where conf is actually used.
I don't have a strong preference, and we can revert if prefered.
Jorjeous
pushed a commit
that referenced
this pull request
Sep 8, 2022
Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: Ante Jukić <[email protected]> Co-authored-by: Ante Jukić <[email protected]> Signed-off-by: George Zelenfroind <[email protected]>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 3, 2022
Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: Ante Jukić <[email protected]> Co-authored-by: Ante Jukić <[email protected]> Signed-off-by: Matvei Novikov <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: Ante Jukić <[email protected]> Co-authored-by: Ante Jukić <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Ante Jukić <[email protected]> Signed-off-by: Ante Jukić <[email protected]> Co-authored-by: Ante Jukić <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR aims to fix a few small issues in the ASR with NeMo tutorial.
Collection: ASR
Changelog
data_direxists and create if necessarydata_dirtopaths2audio_filesUsage
n/a
Before your PR is "Ready for review"
Pre checks:
PR Type:
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
n/a