[Chinese text normalization]Chinese TN part in text_normalization #4826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yzhang123 I make a new pr as a clear version. |
pengzhendong
suggested changes
Aug 27, 2022
Comment on lines
31
to
39
| score = ( | ||
| pynutil.insert("score: \"") | ||
| + Cardinal().graph_cardinal | ||
| + pynini.cross(":", "比") | ||
| + Cardinal().graph_cardinal | ||
| + pynutil.insert("\"") | ||
| ) |
There was a problem hiding this comment.
Please use the symbols from tsv file.
yzhang123
approved these changes
Aug 29, 2022
yzhang123
suggested changes
Aug 29, 2022
| add your sign in data/math/symbol.tsv,this graph just convert sigh to character,you can add more | ||
| cases with detailed cases | ||
| ''' | ||
| score_sign = pynini.string_file(get_abs_path("data/math/score.tsv")) |
There was a problem hiding this comment.
get_abs_path not defined here and and in other files
There was a problem hiding this comment.
sorry for this,which happens with last change trying to add tsv in math.I checked other files and they are correct now.
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: Ubuntu <[email protected]>
Signed-off-by: Ubuntu <[email protected]>
yzhang123
approved these changes
Aug 29, 2022
|
@pengzhendong thanks for your review on this and previous PRs. If nothing more from your side I'm ok to merge. FYI: all pytest and SH tests passed |
|
Hope this is not too late, we received a documentation last week on how to handle numbers from ASR team in Shanghai. Here is the link to it: http://www.moe.gov.cn/ewebeditor/uploadfile/2015/01/13/20150113091154536.pdf |
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 3, 2022
…IDIA#4826) * add zh in normalize Signed-off-by: Ubuntu <[email protected]> * add "zh" in normalize.py Signed-off-by: Ubuntu <[email protected]> * add zh in tools Signed-off-by: Ubuntu <[email protected]> * add zh in test Signed-off-by: Ubuntu <[email protected]> * fix bug in en/graph_utils.py Signed-off-by: Ubuntu <[email protected]> * Update README.md Signed-off-by: Ubuntu <[email protected]> * add score.tsv Signed-off-by: Ubuntu <[email protected]> * update math Signed-off-by: Ubuntu <[email protected]> * add kab language asr models (NVIDIA#4819) Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: Ubuntu <[email protected]> * add import in math Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Ubuntu <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Signed-off-by: Matvei Novikov <[email protected]>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 4, 2022
…IDIA#4826) * add zh in normalize Signed-off-by: Ubuntu <[email protected]> * add "zh" in normalize.py Signed-off-by: Ubuntu <[email protected]> * add zh in tools Signed-off-by: Ubuntu <[email protected]> * add zh in test Signed-off-by: Ubuntu <[email protected]> * fix bug in en/graph_utils.py Signed-off-by: Ubuntu <[email protected]> * Update README.md Signed-off-by: Ubuntu <[email protected]> * add score.tsv Signed-off-by: Ubuntu <[email protected]> * update math Signed-off-by: Ubuntu <[email protected]> * add kab language asr models (NVIDIA#4819) Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: Ubuntu <[email protected]> * add import in math Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Ubuntu <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Signed-off-by: Matvei Novikov <[email protected]>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 4, 2022
…IDIA#4826) * add zh in normalize Signed-off-by: Ubuntu <[email protected]> * add "zh" in normalize.py Signed-off-by: Ubuntu <[email protected]> * add zh in tools Signed-off-by: Ubuntu <[email protected]> * add zh in test Signed-off-by: Ubuntu <[email protected]> * fix bug in en/graph_utils.py Signed-off-by: Ubuntu <[email protected]> * Update README.md Signed-off-by: Ubuntu <[email protected]> * add score.tsv Signed-off-by: Ubuntu <[email protected]> * update math Signed-off-by: Ubuntu <[email protected]> * add kab language asr models (NVIDIA#4819) Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: Ubuntu <[email protected]> * add import in math Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Ubuntu <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Signed-off-by: Matvei Novikov <[email protected]>
jubick1337
pushed a commit
to jubick1337/NeMo
that referenced
this pull request
Oct 4, 2022
…IDIA#4826) * add zh in normalize Signed-off-by: Ubuntu <[email protected]> * add "zh" in normalize.py Signed-off-by: Ubuntu <[email protected]> * add zh in tools Signed-off-by: Ubuntu <[email protected]> * add zh in test Signed-off-by: Ubuntu <[email protected]> * fix bug in en/graph_utils.py Signed-off-by: Ubuntu <[email protected]> * Update README.md Signed-off-by: Ubuntu <[email protected]> * add score.tsv Signed-off-by: Ubuntu <[email protected]> * update math Signed-off-by: Ubuntu <[email protected]> * add kab language asr models (NVIDIA#4819) Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: Ubuntu <[email protected]> * add import in math Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Ubuntu <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Signed-off-by: Matvei Novikov <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
…IDIA#4826) * add zh in normalize Signed-off-by: Ubuntu <[email protected]> * add "zh" in normalize.py Signed-off-by: Ubuntu <[email protected]> * add zh in tools Signed-off-by: Ubuntu <[email protected]> * add zh in test Signed-off-by: Ubuntu <[email protected]> * fix bug in en/graph_utils.py Signed-off-by: Ubuntu <[email protected]> * Update README.md Signed-off-by: Ubuntu <[email protected]> * add score.tsv Signed-off-by: Ubuntu <[email protected]> * update math Signed-off-by: Ubuntu <[email protected]> * add kab language asr models (NVIDIA#4819) Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: Ubuntu <[email protected]> * add import in math Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Ubuntu <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
…IDIA#4826) * add zh in normalize Signed-off-by: Ubuntu <[email protected]> * add "zh" in normalize.py Signed-off-by: Ubuntu <[email protected]> * add zh in tools Signed-off-by: Ubuntu <[email protected]> * add zh in test Signed-off-by: Ubuntu <[email protected]> * fix bug in en/graph_utils.py Signed-off-by: Ubuntu <[email protected]> * Update README.md Signed-off-by: Ubuntu <[email protected]> * add score.tsv Signed-off-by: Ubuntu <[email protected]> * update math Signed-off-by: Ubuntu <[email protected]> * add kab language asr models (NVIDIA#4819) Signed-off-by: nithinraok <[email protected]> Signed-off-by: nithinraok <[email protected]> Signed-off-by: Ubuntu <[email protected]> * add import in math Signed-off-by: Ubuntu <[email protected]> Signed-off-by: Ubuntu <[email protected]> Signed-off-by: nithinraok <[email protected]> Co-authored-by: Nithin Rao <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #4543 & #4638 & #4683
What does this PR do ?
Add Chinese Text Normalization Tools in NeMo
Collection:
[NeMo/norm_text_processing/text_normalization]
[NeMo/tools/text_processing_deployment]
[NeMo/tests/nemo_text_processing/zh]