Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type error in rnnt_wer.py, rnnt_wer_bpe.py, wer_bpe.py #4822

Merged
merged 1 commit into from
Aug 26, 2022
Merged

fix type error in rnnt_wer.py, rnnt_wer_bpe.py, wer_bpe.py #4822

merged 1 commit into from
Aug 26, 2022

Conversation

hainan-xv
Copy link
Collaborator

@hainan-xv hainan-xv commented Aug 26, 2022

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Fix float/integer type error in wer computation. Similar to PR #4816 but on different files.

Changelog

Fix type errors in file rnnt_wer.py, rnnt_wer_bpe.py, wer_bpe.py.

Usage

N/A

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 merged commit 0e57b58 into NVIDIA:main Aug 26, 2022
@hainan-xv hainan-xv deleted the fix_wer_type_error branch August 30, 2022 03:04
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 3, 2022
Signed-off-by: Hainan Xu <[email protected]>

Signed-off-by: Hainan Xu <[email protected]>
Co-authored-by: Hainan Xu <[email protected]>
Signed-off-by: Matvei Novikov <[email protected]>
hainan-xv added a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: Hainan Xu <[email protected]>

Signed-off-by: Hainan Xu <[email protected]>
Co-authored-by: Hainan Xu <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
hainan-xv added a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: Hainan Xu <[email protected]>

Signed-off-by: Hainan Xu <[email protected]>
Co-authored-by: Hainan Xu <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants