Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] use consistent spline interpolation for fastpitch and hifigan. #4679

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented Aug 4, 2022

Signed-off-by: Xuesong Yang [email protected]

What does this PR do ?

Apply consistent spline interpolation when generating mel-spectrograms for finetuing hifigan.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

…hen generating mel-spectrograms for hifigan finetune.

Signed-off-by: Xuesong Yang <[email protected]>
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuesongYang XuesongYang merged commit 543118c into main Aug 5, 2022
@XuesongYang XuesongYang deleted the consistent-interpolation branch August 5, 2022 03:45
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
…hen generating mel-spectrograms for hifigan finetune. (NVIDIA#4679)

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
Jorjeous pushed a commit to Jorjeous/NeMo that referenced this pull request Aug 11, 2022
…hen generating mel-spectrograms for hifigan finetune. (NVIDIA#4679)

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: George <[email protected]>
piraka9011 pushed a commit to piraka9011/NeMo that referenced this pull request Aug 25, 2022
…hen generating mel-spectrograms for hifigan finetune. (NVIDIA#4679)

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
…hen generating mel-spectrograms for hifigan finetune. (NVIDIA#4679)

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants