Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] fixed wrong pronunciations. #4669

Closed
wants to merge 8 commits into from
Closed

[TTS] fixed wrong pronunciations. #4669

wants to merge 8 commits into from

Conversation

XuesongYang
Copy link
Collaborator

Signed-off-by: Xuesong Yang [email protected]

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@XuesongYang
Copy link
Collaborator Author

@jasro23 for vis.

redoctopus
redoctopus previously approved these changes Aug 3, 2022
Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@blisc blisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increment the version number to 22.08

Signed-off-by: ericharper <[email protected]>
blisc
blisc previously approved these changes Aug 4, 2022
@blisc
Copy link
Collaborator

blisc commented Aug 4, 2022

@XuesongYang
Copy link
Collaborator Author

Let's reroute to https://github.com/NVIDIA/NeMo/tree/r1.11.0

Could you pls advise me how to do that? my current understanding is to push the same changes as a new PR to the branch r1.11.0. Is that correct? Thanks. @blisc

@blisc
Copy link
Collaborator

blisc commented Aug 4, 2022

Merged #4677 instead

@blisc blisc closed this Aug 4, 2022
@blisc blisc deleted the fix-pron branch August 4, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants