-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Offline ASR with CTC Decoding #4608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
bmwshop
reviewed
Jul 26, 2022
@@ -538,14 +539,15 @@ def _get_word_offsets_subwords_sentencepiece( | |||
word_offsets.append( | |||
{ | |||
"word": decode_tokens_to_str(built_token), | |||
"start_offset": offsets[i]["start_offset"], | |||
"end_offset": offsets[i]["end_offset"], | |||
"start_offset": offsets[previous_token_index]["start_offset"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense!
bmwshop
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Davood-M
pushed a commit
to Davood-M/NeMo
that referenced
this pull request
Aug 9, 2022
* Fix word boundaries Signed-off-by: smajumdar <[email protected]> * Remove prints Signed-off-by: smajumdar <[email protected]> * Update notebook Signed-off-by: smajumdar <[email protected]> Signed-off-by: David Mosallanezhad <[email protected]>
piraka9011
pushed a commit
to piraka9011/NeMo
that referenced
this pull request
Aug 25, 2022
* Fix word boundaries Signed-off-by: smajumdar <[email protected]> * Remove prints Signed-off-by: smajumdar <[email protected]> * Update notebook Signed-off-by: smajumdar <[email protected]> Signed-off-by: Anas Abou Allaban <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 29, 2022
* Fix word boundaries Signed-off-by: smajumdar <[email protected]> * Remove prints Signed-off-by: smajumdar <[email protected]> * Update notebook Signed-off-by: smajumdar <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add support for subword time stamping using CTC decoding strategy.
Collection: [ASR]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: