Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Offline ASR with CTC Decoding #4608

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Add support for subword time stamping using CTC decoding strategy.

Collection: [ASR]

Changelog

  • Fix mistake in selection of word boundaries for subword models
  • Update tutorial with subword time stamp computation.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
@titu1994 titu1994 requested a review from vsl9 July 25, 2022 23:37
@@ -538,14 +539,15 @@ def _get_word_offsets_subwords_sentencepiece(
word_offsets.append(
{
"word": decode_tokens_to_str(built_token),
"start_offset": offsets[i]["start_offset"],
"end_offset": offsets[i]["end_offset"],
"start_offset": offsets[previous_token_index]["start_offset"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

Copy link
Collaborator

@bmwshop bmwshop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@titu1994 titu1994 merged commit aa0a98c into NVIDIA:main Jul 26, 2022
@titu1994 titu1994 deleted the update_offline_asr branch July 26, 2022 22:14
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
* Fix word boundaries

Signed-off-by: smajumdar <[email protected]>

* Remove prints

Signed-off-by: smajumdar <[email protected]>

* Update notebook

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
piraka9011 pushed a commit to piraka9011/NeMo that referenced this pull request Aug 25, 2022
* Fix word boundaries

Signed-off-by: smajumdar <[email protected]>

* Remove prints

Signed-off-by: smajumdar <[email protected]>

* Update notebook

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Anas Abou Allaban <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* Fix word boundaries

Signed-off-by: smajumdar <[email protected]>

* Remove prints

Signed-off-by: smajumdar <[email protected]>

* Update notebook

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants