Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kw asr models, add itn ru checkpoint (tagger-based) #4595

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

bene-ges
Copy link
Contributor

Signed-off-by: Alexandra Antonova [email protected]

What does this PR do ?

Add two ASR models for Kinyarwanda (ctc and transducer large), add tagger-based ITN model for Russian

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@bene-ges bene-ges requested a review from titu1994 July 25, 2022 08:15
@titu1994
Copy link
Collaborator

Please add the language to https://github.com/NVIDIA/NeMo/blob/main/docs/source/asr/results.rst, with corresponding csv file in correct directory.

Alexandra Antonova added 2 commits July 25, 2022 20:15
Signed-off-by: Alexandra Antonova <[email protected]>
@bene-ges bene-ges force-pushed the add_checkpoints_asr_rw_and_itn_ru branch from e0b1e13 to de446f7 Compare July 25, 2022 17:15
@titu1994 titu1994 merged commit 468a3f3 into main Jul 25, 2022
@titu1994 titu1994 deleted the add_checkpoints_asr_rw_and_itn_ru branch July 25, 2022 20:26
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
* add kw asr models, add itn ru checkpoint (tagger-based)

Signed-off-by: Alexandra Antonova <[email protected]>

* add rw results to docs

Signed-off-by: Alexandra Antonova <[email protected]>

Co-authored-by: Alexandra Antonova <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
* add kw asr models, add itn ru checkpoint (tagger-based)

Signed-off-by: Alexandra Antonova <[email protected]>

* add rw results to docs

Signed-off-by: Alexandra Antonova <[email protected]>

Co-authored-by: Alexandra Antonova <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants