Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS][ASR] customize arguments for trimming the leading/trailing silence #4582

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented Jul 22, 2022

What does this PR do ?

It supports overriding arguments of librosa.effects.trim when trimming silence. By default, we assign trim: false in YAML config. But when enabling it by trim: true, you have options to override original arguments of librosa.effects.trim, for example,

 trim: true
  trim_top_db: 50,
  trim_frame_length: ${model.n_window_size},
  trim_hop_length: ${model.n_window_stride},

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@XuesongYang XuesongYang requested review from rlangman and titu1994 and removed request for titu1994 July 26, 2022 00:29
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine, I will leave to Ryan for final review

Copy link
Collaborator

@rlangman rlangman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for adding this.

Copy link
Collaborator

@redoctopus redoctopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuesongYang XuesongYang merged commit 5686fe2 into main Jul 26, 2022
@XuesongYang XuesongYang deleted the trim-sil-fix branch July 26, 2022 17:20
Davood-M pushed a commit to Davood-M/NeMo that referenced this pull request Aug 9, 2022
…nce (NVIDIA#4582)

[TTS][ASR] enabled overriding arguments for trimming the leading and trailing silence using librosa.effects.trim

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: David Mosallanezhad <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
…nce (NVIDIA#4582)

[TTS][ASR] enabled overriding arguments for trimming the leading and trailing silence using librosa.effects.trim

Signed-off-by: Xuesong Yang <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants