-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTS][ASR] customize arguments for trimming the leading/trailing silence #4582
Conversation
…d trailing silence. Signed-off-by: Xuesong Yang <[email protected]>
7e4c846
to
f5d9cff
Compare
Signed-off-by: Xuesong Yang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fine, I will leave to Ryan for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for adding this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nce (NVIDIA#4582) [TTS][ASR] enabled overriding arguments for trimming the leading and trailing silence using librosa.effects.trim Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: David Mosallanezhad <[email protected]>
…nce (NVIDIA#4582) [TTS][ASR] enabled overriding arguments for trimming the leading and trailing silence using librosa.effects.trim Signed-off-by: Xuesong Yang <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
What does this PR do ?
It supports overriding arguments of
librosa.effects.trim
when trimming silence. By default, we assigntrim: false
in YAML config. But when enabling it bytrim: true
, you have options to override original arguments oflibrosa.effects.trim
, for example,Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information