[collections] bugfix for capturing NotImplementedError of non-supported sup data types.

[XuesongYang]

What does this PR do ?

Fixed the bug that does not correctly capture NotImplementedError of non-supported supplementary data types. Original implementation as shown in https://github.com/NVIDIA/NeMo/blob/main/nemo/collections/tts/torch/data.py#L262-L263 will not raise any exception ever because the data_type has already been validated by looking it up in DATA_STR2DATA_CLASS in line 257.

Collection: [Note which collection this PR will affect]
nemo/collections/tts/torch/data.py

Changelog

• Add specific line by line info of high level changes in this PR.

Usage

• You can potentially add a usage example below

# added a unit test for the function.
$ pytest --cpu tests/collections/tts/test_torch_tts.py::TestTTSDataset::test_raise_exception_on_not_supported_sup_data_types

========================================= test session starts =========================================
platform linux -- Python 3.8.13, pytest-7.1.1, pluggy-1.0.0 -- /home/xueyang/miniconda3/envs/nemo/bin/python
cachedir: .pytest_cache
rootdir: /home/xueyang/workspace/NeMo, configfile: setup.cfg
plugins: hydra-core-1.1.1
collected 1 item

tests/collections/tts/test_torch_tts.py::TestTTSDataset::test_raise_exception_on_not_supported_sup_data_types PASSED [100%]
==================================== 1 passed, 3 warnings in 2.95s ====================================

Before your PR is "Ready for review"

Pre checks:

• Make sure you read and followed Contributor guidelines
• Did you write any new necessary tests?
• Did you add or update any necessary documentation?
• Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
  • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

• New Feature
• Bugfix
• Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

• Related to # (issue)

[lgtm-com]

This pull request introduces 1 alert when merging 8f80086 into f9d45db - view on LGTM.com

new alerts:

• 1 for Unused import

[lgtm-com]

This pull request introduces 1 alert when merging 388bcb2 into f9d45db - view on LGTM.com

new alerts:

• 1 for Unused import

[redoctopus]

LGTM

[titu1994]

Looks correct to me.