Prompt tokenization bugfix #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Virginia Adams <[email protected]>
Signed-off-by: Virginia Adams <[email protected]>
yidong72
reviewed
May 18, 2022
| @@ -71,8 +71,8 @@ def get_task_templates(): | |||
| "task_id_num": 0, | |||
| } | |||
| task_templates['task name B'] = { | |||
| "prompt_template": "<|VIRTUAL_PROMPT_0|>{question}<|VIRTUAL_PROMPT_1|>{answer}{extra}", | |||
| "prompt_template_fields": ['question', 'answer'], | |||
| "prompt_template": "<|VIRTUAL_PROMPT_0|> {question} <|VIRTUAL_PROMPT_1|> {answer}{extra}", | |||
There was a problem hiding this comment.
why you add the space around the virtual tokens? If space is needed, virtual prompt should learn to be a space embedding?
There was a problem hiding this comment.
I was playing around with the unit tests to help diagnose a bug with the huggingface tokenizer. This change isn't needed, I just forgot to put it back. I removed the spaces so they should be back the way they were.
| ] | ||
|
|
||
| return pseudo_tokens | ||
|
|
There was a problem hiding this comment.
I see you have the similar logics in the prompt_lenaring_model file. Put the function there?
Signed-off-by: Virginia Adams <[email protected]>
yaoyu-33
pushed a commit
that referenced
this pull request
May 24, 2022
* Updated default virtual token placeholder Signed-off-by: Virginia Adams <[email protected]> * Python style fix Signed-off-by: Virginia Adams <[email protected]> * Addressed reviewer comments Signed-off-by: Virginia Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Collection: BigNLP
Changelog
Updated megatron_gpt_prompt_learning_model
Updated prompt learning dataset unit tests
Added Enum for virtual prompt token string
Usage
Same as before
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information