Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename folder VAD -> vad #4163

Merged
merged 6 commits into from
May 16, 2022
Merged

rename folder VAD -> vad #4163

merged 6 commits into from
May 16, 2022

Conversation

fayejf
Copy link
Collaborator

@fayejf fayejf commented May 12, 2022

Signed-off-by: fayejf [email protected]

What does this PR do ?

rename VAD folder in examples/asr/conf/ to vad and update files accordingly.

Collection:ASR

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@fayejf fayejf requested a review from titu1994 May 12, 2022 22:12
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@fayejf fayejf merged commit 2325ad0 into r1.9.0 May 16, 2022
@fayejf fayejf deleted the lowercase_vad_folder_name branch May 16, 2022 22:03
ericharper pushed a commit that referenced this pull request May 18, 2022
ericharper added a commit that referenced this pull request May 20, 2022
* update branch

Signed-off-by: ericharper <[email protected]>

* update package info

Signed-off-by: ericharper <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

* Restored tests previously disabled for 22.03 base (#4109)

Signed-off-by: Boris Fomitchev <[email protected]>

* add augmentation to label models (#4113)

* add augmentation to label models

Signed-off-by: nithinraok <[email protected]>

* duration fix

Signed-off-by: nithinraok <[email protected]>

* Call register_bert_model after assigning self.bert_model variable (#4116)

Signed-off-by: Ramanathan Arunachalam <[email protected]>

Co-authored-by: Ramanathan Arunachalam <[email protected]>

* Tutorial on ITN with Thutmose tagger and small fixes (#4117)

* 1. Add tutorial. 2. Move a function to fix import in tutorial. 3. Merge multiple spaces into one space in the final output

Signed-off-by: Alexandra Antonova <[email protected]>

* fixes for code review

Signed-off-by: Alexandra Antonova <[email protected]>

* Add tutorial to tutorials.rst

Signed-off-by: Alexandra Antonova <[email protected]>

Co-authored-by: Alexandra Antonova <[email protected]>

* cleaned up TN/ ITN doc (#4119)

* cleaned up TN/ ITN doc

Signed-off-by: Yang Zhang <[email protected]>

* fix typo

Signed-off-by: Yang Zhang <[email protected]>

* fix image

Signed-off-by: Yang Zhang <[email protected]>

* fix image

Signed-off-by: Yang Zhang <[email protected]>

* Check implicit grad acc in GLUE dataset building (#4123)

* Check implicit grad acc in GLUE dataset building

Signed-off-by: MaximumEntropy <[email protected]>

* Fix jenkins test for GLUE/XNLI

Signed-off-by: MaximumEntropy <[email protected]>

* update the default (#4135)

Signed-off-by: ekmb <[email protected]>

* Fix/punctuation avoid overwritting tmp files (#4144)

* Add draft of fixing tmp files overwritting

Signed-off-by: PeganovAnton <[email protected]>

* Remove accidental changes

Signed-off-by: PeganovAnton <[email protected]>

* Remove accidental changes

Signed-off-by: PeganovAnton <[email protected]>

* Use built-in tempfile library

Signed-off-by: PeganovAnton <[email protected]>

* Fix code style

Signed-off-by: PeganovAnton <[email protected]>

* bug_fix_diarization_manifest_creation (#4125)

Signed-off-by: Yang Zhang <[email protected]>

Co-authored-by: Nithin Rao <[email protected]>

* fix doc (#4146)

Signed-off-by: Yang Zhang <[email protected]>

* Tacotron2 retrain (#4103)

* fix yaml

Signed-off-by: treacker <[email protected]>

* Fix for new TTSDataset class

Signed-off-by: treacker <[email protected]>

* added wandb logging

Signed-off-by: treacker <[email protected]>

* added wandb logging

Signed-off-by: treacker <[email protected]>

* fix numpy version

Signed-off-by: treacker <[email protected]>

* fix numpy version

Signed-off-by: treacker <[email protected]>

* inference fix

Signed-off-by: treacker <[email protected]>

* removed old code

Signed-off-by: treacker <[email protected]>

* updated parser logic

Signed-off-by: treacker <[email protected]>

* reverted version update

Signed-off-by: treacker <[email protected]>

* refactored parser logic

Signed-off-by: treacker <[email protected]>

* Updated Jenkinsfile

Signed-off-by: treacker <[email protected]>

* Refactored tutorial for Tacotron2

Signed-off-by: treacker <[email protected]>

* Made backward compatibility

Signed-off-by: treacker <[email protected]>

* Made backward compatibility

Signed-off-by: treacker <[email protected]>

* Update Jenkinsfile

Signed-off-by: treacker <[email protected]>

* Update tacotron.yaml

Signed-off-by: treacker <[email protected]>

* Refactoring

Signed-off-by: treacker <[email protected]>

* cleaned up TN/ ITN doc (#4119)

* cleaned up TN/ ITN doc

Signed-off-by: Yang Zhang <[email protected]>

* fix typo

Signed-off-by: Yang Zhang <[email protected]>

* fix image

Signed-off-by: Yang Zhang <[email protected]>

* fix image

Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: treacker <[email protected]>

* Check implicit grad acc in GLUE dataset building (#4123)

* Check implicit grad acc in GLUE dataset building

Signed-off-by: MaximumEntropy <[email protected]>

* Fix jenkins test for GLUE/XNLI

Signed-off-by: MaximumEntropy <[email protected]>
Signed-off-by: treacker <[email protected]>

* Refactoring

Signed-off-by: treacker <[email protected]>

* Refactoring

Signed-off-by: treacker <[email protected]>

* Fixed jenkins

Signed-off-by: treacker <[email protected]>

* Refactoring

Signed-off-by: treacker <[email protected]>

* Refactoring

Signed-off-by: treacker <[email protected]>

* Refactoring

Signed-off-by: treacker <[email protected]>

Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>

* Multiprocess improvements (#4127)

* initial commit

Signed-off-by: nithinraok <[email protected]>

* start fix

Signed-off-by: nithinraok <[email protected]>

* improve multiprocessing speed while creating speaker dataset

Signed-off-by: nithinraok <[email protected]>

* updated scp to filelist

Signed-off-by: nithinraok <[email protected]>

* WaveGlow input type fixes (#4151)

Signed-off-by: Jocelyn Huang <[email protected]>

* notebooks' link, typo and import  fix  (#4158)

* redo missing pr 4007

Signed-off-by: fayejf <[email protected]>

* remove extremely unreliable links

Signed-off-by: fayejf <[email protected]>

* Thutmose tagger bug fixes (#4162)

* add pretrained ngc model, small fixes

Signed-off-by: Alexandra Antonova <[email protected]>

* fix model location

Signed-off-by: Alexandra Antonova <[email protected]>

* fix model location

Signed-off-by: Alexandra Antonova <[email protected]>

* 1. fix typos. 2. write magic functions without space

Signed-off-by: Alexandra Antonova <[email protected]>

* add example of inference with pretrained model

Signed-off-by: Alexandra Antonova <[email protected]>

* changed model location to nemo

Signed-off-by: Alexandra Antonova <[email protected]>

* style fix

Signed-off-by: Alexandra Antonova <[email protected]>

* fix space

Signed-off-by: Alexandra Antonova <[email protected]>

Co-authored-by: Alexandra Antonova <[email protected]>

* update speaker docs (#4164)

* update speaker docs

Signed-off-by: nithinraok <[email protected]>

* chunks -> segments

Signed-off-by: nithinraok <[email protected]>

* Khz -> kHz

Signed-off-by: nithinraok <[email protected]>

* set plugin to None when no apex (#4171)

Signed-off-by: ekmb <[email protected]>

* small fix (#4180)

Signed-off-by: fayejf <[email protected]>

* rename folder VAD->vad (#4163)

Signed-off-by: fayejf <[email protected]>

* fix the server key value problem (#4196)

Signed-off-by: Yi Dong <[email protected]>

* update branch

Signed-off-by: ericharper <[email protected]>

* update package info and dockerfile

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Boris Fomitchev <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: Ramanathan Arunachalam <[email protected]>
Co-authored-by: Ramanathan Arunachalam <[email protected]>
Co-authored-by: bene-ges <[email protected]>
Co-authored-by: Alexandra Antonova <[email protected]>
Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Sandeep Subramanian <[email protected]>
Co-authored-by: Evelina <[email protected]>
Co-authored-by: PeganovAnton <[email protected]>
Co-authored-by: treacker <[email protected]>
Co-authored-by: Jocelyn <[email protected]>
Co-authored-by: fayejf <[email protected]>
Co-authored-by: Yi Dong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants