-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialogue task #3884
Dialogue task #3884
Conversation
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
…_init__.py Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging c3c3f25 into 75c1668 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging 4fe591b into 75c1668 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Zhilin Wang <[email protected]>
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging 4926bd1 into 75c1668 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging a761b7b into b93a64a - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging c5ac004 into d97e0d3 - view on LGTM.com new alerts:
fixed alerts:
|
…apex Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging 943cf59 into 6b6e881 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging 1b5766d into da1b56c - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 3 alerts and fixes 5 when merging 690bdab into 0d052c8 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and tutorial notebook. This is looking good. One thing I think is important to flesh out is what the different pretrained language model options are and how the naming works. Maybe it is obvious us that 'gpt2' is going to rely on the eponymous HuggingFace gpt2 model, but I'm not sure it'll be obvious to a new person approaching this framework. Similarly for models on NGC, how can they determine which models are compatible, how does the naming work, do they need to download the model, etc.
I have a couple suggestions for future improvements of the notebook (not for this PR). The real power of your approach is its modularity, especially the ability to swap out language models with different architectures for the same task. I think it would be cool to show that off in the notebook by adding an example where you train on the same data/task with a different model type. I would also like to see some examples of the input data displayed. You can see this in some of the other nemo tutorials. There is sometimes a cell that displays a few training examples to give the user a peek. Finally, you could also add some more information about inference to the tutorial. Maybe show an example of reloading a model that was previously fine tuned in the notebook and running inference.
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 4 alerts and fixes 5 when merging fb32ff0 into f776442 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Zhilin Wang <[email protected]>
This pull request introduces 2 alerts and fixes 5 when merging e15d655 into f776442 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 2 alerts and fixes 5 when merging 24adbd5 into 655ff80 - view on LGTM.com new alerts:
fixed alerts:
|
What does this PR do ?
Add various functionalities to dialogue domain for NeMo
Collection: NLP
Changelog
See details in NVIDIA only dev log
Usage
# Add a code snippet demonstrating how to use this
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information