-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fr asr ckpt to doc #3809
Merged
add fr asr ckpt to doc #3809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <[email protected]>
titu1994
approved these changes
Mar 8, 2022
crcrpar
pushed a commit
to crcrpar/NeMo
that referenced
this pull request
Mar 11, 2022
Signed-off-by: Yang Zhang <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Mar 12, 2022
Signed-off-by: Yang Zhang <[email protected]>
ericharper
added a commit
that referenced
this pull request
Mar 14, 2022
…nto account (#3826) * initial fix: taking data parallel size into consideration Signed-off-by: Masaki Kozuki <[email protected]> * update the signature Signed-off-by: Masaki Kozuki <[email protected]> * data_parallel_rank -> data_parallel_size Signed-off-by: Masaki Kozuki <[email protected]> * fix typo Signed-off-by: Masaki Kozuki <[email protected]> * cosmetic changes Signed-off-by: Masaki Kozuki <[email protected]> * Revert "update the signature" This reverts commit 1c134e5. Signed-off-by: Masaki Kozuki <[email protected]> * update batch_sampler arguments Signed-off-by: Masaki Kozuki <[email protected]> * change how to slice `batch` Signed-off-by: Masaki Kozuki <[email protected]> * update not drop_last path Signed-off-by: Masaki Kozuki <[email protected]> * add fr asr ckpt to doc (#3809) Signed-off-by: Yang Zhang <[email protected]> * bert_module: fix inputs of exported model (#3815) Exported ONNX model had to be passed with "attention_mask" and "token_type_ids" inputs swapped to get correct output. Changing the input order fixes this issue. Also return a dict instead of list for correctly passing inputs. Update relevant tests: test_TokenClassificationModel_export_to_onnx test_PunctuationCapitalizationModel_export_to_onnx test_QAModel_export_to_onnx Signed-off-by: Viraj Karandikar <[email protected]> Co-authored-by: Yang Zhang <[email protected]> * update random batch sampler Signed-off-by: Masaki Kozuki <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Co-authored-by: Viraj Karandikar <[email protected]> Co-authored-by: Eric Harper <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Mar 22, 2022
Signed-off-by: Yang Zhang <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Mar 22, 2022
…nto account (#3826) * initial fix: taking data parallel size into consideration Signed-off-by: Masaki Kozuki <[email protected]> * update the signature Signed-off-by: Masaki Kozuki <[email protected]> * data_parallel_rank -> data_parallel_size Signed-off-by: Masaki Kozuki <[email protected]> * fix typo Signed-off-by: Masaki Kozuki <[email protected]> * cosmetic changes Signed-off-by: Masaki Kozuki <[email protected]> * Revert "update the signature" This reverts commit 1c134e5. Signed-off-by: Masaki Kozuki <[email protected]> * update batch_sampler arguments Signed-off-by: Masaki Kozuki <[email protected]> * change how to slice `batch` Signed-off-by: Masaki Kozuki <[email protected]> * update not drop_last path Signed-off-by: Masaki Kozuki <[email protected]> * add fr asr ckpt to doc (#3809) Signed-off-by: Yang Zhang <[email protected]> * bert_module: fix inputs of exported model (#3815) Exported ONNX model had to be passed with "attention_mask" and "token_type_ids" inputs swapped to get correct output. Changing the input order fixes this issue. Also return a dict instead of list for correctly passing inputs. Update relevant tests: test_TokenClassificationModel_export_to_onnx test_PunctuationCapitalizationModel_export_to_onnx test_QAModel_export_to_onnx Signed-off-by: Viraj Karandikar <[email protected]> Co-authored-by: Yang Zhang <[email protected]> * update random batch sampler Signed-off-by: Masaki Kozuki <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Co-authored-by: Viraj Karandikar <[email protected]> Co-authored-by: Eric Harper <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Mar 22, 2022
Signed-off-by: Yang Zhang <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Mar 22, 2022
…nto account (#3826) * initial fix: taking data parallel size into consideration Signed-off-by: Masaki Kozuki <[email protected]> * update the signature Signed-off-by: Masaki Kozuki <[email protected]> * data_parallel_rank -> data_parallel_size Signed-off-by: Masaki Kozuki <[email protected]> * fix typo Signed-off-by: Masaki Kozuki <[email protected]> * cosmetic changes Signed-off-by: Masaki Kozuki <[email protected]> * Revert "update the signature" This reverts commit 1c134e5. Signed-off-by: Masaki Kozuki <[email protected]> * update batch_sampler arguments Signed-off-by: Masaki Kozuki <[email protected]> * change how to slice `batch` Signed-off-by: Masaki Kozuki <[email protected]> * update not drop_last path Signed-off-by: Masaki Kozuki <[email protected]> * add fr asr ckpt to doc (#3809) Signed-off-by: Yang Zhang <[email protected]> * bert_module: fix inputs of exported model (#3815) Exported ONNX model had to be passed with "attention_mask" and "token_type_ids" inputs swapped to get correct output. Changing the input order fixes this issue. Also return a dict instead of list for correctly passing inputs. Update relevant tests: test_TokenClassificationModel_export_to_onnx test_PunctuationCapitalizationModel_export_to_onnx test_QAModel_export_to_onnx Signed-off-by: Viraj Karandikar <[email protected]> Co-authored-by: Yang Zhang <[email protected]> * update random batch sampler Signed-off-by: Masaki Kozuki <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Co-authored-by: Viraj Karandikar <[email protected]> Co-authored-by: Eric Harper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Zhang [email protected]
What does this PR do ?
add fr asr model ckpt to doc