Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fr asr ckpt to doc #3809

Merged
merged 2 commits into from
Mar 11, 2022
Merged

add fr asr ckpt to doc #3809

merged 2 commits into from
Mar 11, 2022

Conversation

yzhang123
Copy link
Contributor

Signed-off-by: Yang Zhang [email protected]

What does this PR do ?

add fr asr model ckpt to doc

Signed-off-by: Yang Zhang <[email protected]>
@yzhang123 yzhang123 merged commit da2b402 into main Mar 11, 2022
@yzhang123 yzhang123 deleted the doc_fr branch March 11, 2022 16:43
crcrpar pushed a commit to crcrpar/NeMo that referenced this pull request Mar 11, 2022
fayejf pushed a commit that referenced this pull request Mar 12, 2022
ericharper added a commit that referenced this pull request Mar 14, 2022
…nto account (#3826)

* initial fix: taking data parallel size into consideration

Signed-off-by: Masaki Kozuki <[email protected]>

* update the signature

Signed-off-by: Masaki Kozuki <[email protected]>

* data_parallel_rank -> data_parallel_size

Signed-off-by: Masaki Kozuki <[email protected]>

* fix typo

Signed-off-by: Masaki Kozuki <[email protected]>

* cosmetic changes

Signed-off-by: Masaki Kozuki <[email protected]>

* Revert "update the signature"

This reverts commit 1c134e5.

Signed-off-by: Masaki Kozuki <[email protected]>

* update batch_sampler arguments

Signed-off-by: Masaki Kozuki <[email protected]>

* change how to slice `batch`

Signed-off-by: Masaki Kozuki <[email protected]>

* update not drop_last path

Signed-off-by: Masaki Kozuki <[email protected]>

* add fr asr ckpt to doc (#3809)

Signed-off-by: Yang Zhang <[email protected]>

* bert_module: fix inputs of exported model (#3815)

Exported ONNX model had to be passed with "attention_mask" and
"token_type_ids" inputs swapped to get correct output.

Changing the input order fixes this issue.
Also return a dict instead of list for correctly passing inputs.

Update relevant tests:
test_TokenClassificationModel_export_to_onnx
test_PunctuationCapitalizationModel_export_to_onnx
test_QAModel_export_to_onnx

Signed-off-by: Viraj Karandikar <[email protected]>

Co-authored-by: Yang Zhang <[email protected]>

* update random batch sampler

Signed-off-by: Masaki Kozuki <[email protected]>

Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Viraj Karandikar <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
fayejf pushed a commit that referenced this pull request Mar 22, 2022
fayejf pushed a commit that referenced this pull request Mar 22, 2022
…nto account (#3826)

* initial fix: taking data parallel size into consideration

Signed-off-by: Masaki Kozuki <[email protected]>

* update the signature

Signed-off-by: Masaki Kozuki <[email protected]>

* data_parallel_rank -> data_parallel_size

Signed-off-by: Masaki Kozuki <[email protected]>

* fix typo

Signed-off-by: Masaki Kozuki <[email protected]>

* cosmetic changes

Signed-off-by: Masaki Kozuki <[email protected]>

* Revert "update the signature"

This reverts commit 1c134e5.

Signed-off-by: Masaki Kozuki <[email protected]>

* update batch_sampler arguments

Signed-off-by: Masaki Kozuki <[email protected]>

* change how to slice `batch`

Signed-off-by: Masaki Kozuki <[email protected]>

* update not drop_last path

Signed-off-by: Masaki Kozuki <[email protected]>

* add fr asr ckpt to doc (#3809)

Signed-off-by: Yang Zhang <[email protected]>

* bert_module: fix inputs of exported model (#3815)

Exported ONNX model had to be passed with "attention_mask" and
"token_type_ids" inputs swapped to get correct output.

Changing the input order fixes this issue.
Also return a dict instead of list for correctly passing inputs.

Update relevant tests:
test_TokenClassificationModel_export_to_onnx
test_PunctuationCapitalizationModel_export_to_onnx
test_QAModel_export_to_onnx

Signed-off-by: Viraj Karandikar <[email protected]>

Co-authored-by: Yang Zhang <[email protected]>

* update random batch sampler

Signed-off-by: Masaki Kozuki <[email protected]>

Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Viraj Karandikar <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
fayejf pushed a commit that referenced this pull request Mar 22, 2022
fayejf pushed a commit that referenced this pull request Mar 22, 2022
…nto account (#3826)

* initial fix: taking data parallel size into consideration

Signed-off-by: Masaki Kozuki <[email protected]>

* update the signature

Signed-off-by: Masaki Kozuki <[email protected]>

* data_parallel_rank -> data_parallel_size

Signed-off-by: Masaki Kozuki <[email protected]>

* fix typo

Signed-off-by: Masaki Kozuki <[email protected]>

* cosmetic changes

Signed-off-by: Masaki Kozuki <[email protected]>

* Revert "update the signature"

This reverts commit 1c134e5.

Signed-off-by: Masaki Kozuki <[email protected]>

* update batch_sampler arguments

Signed-off-by: Masaki Kozuki <[email protected]>

* change how to slice `batch`

Signed-off-by: Masaki Kozuki <[email protected]>

* update not drop_last path

Signed-off-by: Masaki Kozuki <[email protected]>

* add fr asr ckpt to doc (#3809)

Signed-off-by: Yang Zhang <[email protected]>

* bert_module: fix inputs of exported model (#3815)

Exported ONNX model had to be passed with "attention_mask" and
"token_type_ids" inputs swapped to get correct output.

Changing the input order fixes this issue.
Also return a dict instead of list for correctly passing inputs.

Update relevant tests:
test_TokenClassificationModel_export_to_onnx
test_PunctuationCapitalizationModel_export_to_onnx
test_QAModel_export_to_onnx

Signed-off-by: Viraj Karandikar <[email protected]>

Co-authored-by: Yang Zhang <[email protected]>

* update random batch sampler

Signed-off-by: Masaki Kozuki <[email protected]>

Co-authored-by: Yang Zhang <[email protected]>
Co-authored-by: Viraj Karandikar <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants