Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Camembert Huggingface bert-like models #3799

Merged
merged 7 commits into from
Mar 9, 2022

Conversation

itzsimpl
Copy link
Contributor

@itzsimpl itzsimpl commented Mar 5, 2022

Signed-off-by: Iztok Lebar Bajec [email protected]

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: nlp

Changelog

Usage

  • You can potentially add a usage example below
    In /examples/nlp/token_classification/conf/punctuation_capitalization_config.yaml set
pretrained_model_name: camembert-base

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@ekmb ekmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Please run cd NeMo/ && python setup.py style --fix to fix style errors.

Signed-off-by: Iztok Lebar Bajec <[email protected]>
@itzsimpl
Copy link
Contributor Author

itzsimpl commented Mar 8, 2022

As for running cd NeMo/ && python setup.py style --fix the command requires isort (not in NeMo requirements.txt and not customarily installed, so a heads up would be welcome). After installing it, it still fails with the following:

$ python setup.py style --fix
running style
Running command: isort --multi-line=3 --trailing-comma --force-grid-wrap=0 --use-parentheses --line-width=119 -rc -ws .
ERROR: Found nemo_text_processing.text_normalization.normalize import while parsing, but FIRSTPARTY was not included in the `sections` setting of your config. Please add it before continuing
See https://pycqa.github.io/isort/#custom-sections-and-ordering for more info.
Running command: black --skip-string-normalization --line-length=119 .
error: [Errno 2] No such file or directory: 'black'

Since none of these were modified by this PR I left everything as is.

@itzsimpl itzsimpl requested a review from ekmb March 8, 2022 21:10
@ekmb
Copy link
Collaborator

ekmb commented Mar 8, 2022

Right, the CI is failing due to the style issues of the newly added files. Have you installed NeMo by running ./reinstall.sh?
black/isort is a part of https://github.com/NVIDIA/NeMo/blob/main/requirements/requirements_test.txt

@itzsimpl
Copy link
Contributor Author

itzsimpl commented Mar 9, 2022

Ok, thnx, I was using pip install -e ., had to run ./reinstall.sh inside a container and then in it python setup.py style --fix.

@ekmb ekmb merged commit 51c9c0a into NVIDIA:main Mar 9, 2022
@ekmb
Copy link
Collaborator

ekmb commented Mar 9, 2022

@itzsimpl, thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants