-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Camembert Huggingface bert-like models #3799
Conversation
Signed-off-by: Iztok Lebar Bajec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Please run cd NeMo/ && python setup.py style --fix
to fix style errors.
Signed-off-by: Iztok Lebar Bajec <[email protected]>
As for running $ python setup.py style --fix
running style
Running command: isort --multi-line=3 --trailing-comma --force-grid-wrap=0 --use-parentheses --line-width=119 -rc -ws .
ERROR: Found nemo_text_processing.text_normalization.normalize import while parsing, but FIRSTPARTY was not included in the `sections` setting of your config. Please add it before continuing
See https://pycqa.github.io/isort/#custom-sections-and-ordering for more info.
Running command: black --skip-string-normalization --line-length=119 .
error: [Errno 2] No such file or directory: 'black' Since none of these were modified by this PR I left everything as is. |
Right, the CI is failing due to the style issues of the newly added files. Have you installed NeMo by running |
Signed-off-by: Iztok Lebar Bajec <[email protected]>
Ok, thnx, I was using |
@itzsimpl, thanks for your PR! |
Signed-off-by: Iztok Lebar Bajec [email protected]
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: nlp
Changelog
Usage
In
/examples/nlp/token_classification/conf/punctuation_capitalization_config.yaml
setBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information