Update numba if NVIDIA_PYTORCH_VERSION not correct #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update/install numba if `NVIDIA_PYTORCH_VERSION` is not equal to the one in `Dockerfile`. Resolves #3613 Signed-off-by: Iztok Lebar Bajec <[email protected]>
titu1994
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
I'm wondering if Numba should be commented out for the time being because of it's incompatibility with Numpy. Pushing it to the top just means it needs to be installed before Nemo itself now. Well, that is fine for now but I will revert this when the next Numba rc version is released.
fayejf
pushed a commit
that referenced
this pull request
Mar 2, 2022
Update/install numba if `NVIDIA_PYTORCH_VERSION` is not equal to the one in `Dockerfile`. Resolves #3613 Signed-off-by: Iztok Lebar Bajec <[email protected]> Co-authored-by: Oleksii Kuchaiev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update/install numba if
NVIDIA_PYTORCH_VERSIONis not equal to the one inDockerfile. Resolves #3613Signed-off-by: Iztok Lebar Bajec [email protected]