Update pr template and re-add Changelog builder #3575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
Signed-off-by: smajumdar <[email protected]>
ericharper
reviewed
Feb 1, 2022
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| # What does this PR do? | ||
| **Collection**: [Note which collection this PR will affect] |
There was a problem hiding this comment.
I think we still need a header here, or people are going to miss filling out the collection.
ericharper
reviewed
Feb 1, 2022
.github/PULL_REQUEST_TEMPLATE.md
Outdated
Comment on lines
21
to
23
| **PR Type**: | ||
| - [ ] Bugfix | ||
| - [ ] Documentation |
There was a problem hiding this comment.
Can we add - [ ] New Feature or something like that?
There was a problem hiding this comment.
New feature is the default and would almost always be selected though ?
ericharper
requested changes
Feb 1, 2022
ericharper
approved these changes
Feb 1, 2022
nithinraok
pushed a commit
that referenced
this pull request
Feb 2, 2022
* Update changelog to add authors Signed-off-by: smajumdar <[email protected]> * Update changelog to add authors Signed-off-by: smajumdar <[email protected]> * Update changelog to add authors Signed-off-by: smajumdar <[email protected]> * Correct configS Signed-off-by: smajumdar <[email protected]> * Correct configS Signed-off-by: smajumdar <[email protected]> * Correct configS Signed-off-by: smajumdar <[email protected]> * Update changelog Signed-off-by: smajumdar <[email protected]> * Fix extra , Signed-off-by: smajumdar <[email protected]> * Update according to suggestions Signed-off-by: smajumdar <[email protected]> Co-authored-by: Eric Harper <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Mar 2, 2022
* Update changelog to add authors Signed-off-by: smajumdar <[email protected]> * Update changelog to add authors Signed-off-by: smajumdar <[email protected]> * Update changelog to add authors Signed-off-by: smajumdar <[email protected]> * Correct configS Signed-off-by: smajumdar <[email protected]> * Correct configS Signed-off-by: smajumdar <[email protected]> * Correct configS Signed-off-by: smajumdar <[email protected]> * Update changelog Signed-off-by: smajumdar <[email protected]> * Fix extra , Signed-off-by: smajumdar <[email protected]> * Update according to suggestions Signed-off-by: smajumdar <[email protected]> Co-authored-by: Eric Harper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection: [docs]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.