Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce legacy tokenizer for sentencepiece to add special tokens for T5 #3457

Merged
merged 4 commits into from
Jan 21, 2022

Conversation

MaximumEntropy
Copy link
Contributor

No description provided.

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks correct to me, and Citrinets work without breaking so its ok from my side. Leaving another reviewer for NMT side review.

@titu1994 titu1994 merged commit b756d53 into main Jan 21, 2022
@titu1994 titu1994 deleted the t5_sentencepiece_legacy branch January 21, 2022 02:15
nithinraok pushed a commit that referenced this pull request Feb 2, 2022
…T5 (#3457)

* Set tokenizer to legacy if using spm with t5

Signed-off-by: MaximumEntropy <[email protected]>

* Style fixes

Signed-off-by: MaximumEntropy <[email protected]>
fayejf pushed a commit that referenced this pull request Mar 2, 2022
…T5 (#3457)

* Set tokenizer to legacy if using spm with t5

Signed-off-by: MaximumEntropy <[email protected]>

* Style fixes

Signed-off-by: MaximumEntropy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants