Relative paths in tarred dataset #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rying to look for file in same path as metadata file. Signed-off-by: Micha Livne <[email protected]>
Signed-off-by: Micha Livne <[email protected]>
Signed-off-by: Micha Livne <[email protected]>
Signed-off-by: Micha Livne <[email protected]>
paarthneekhara
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Sep 17, 2021
* 1. Added on-the-fly validation of tarred dataset files. If missing, trying to look for file in same path as metadata file. Signed-off-by: Micha Livne <[email protected]> * 1. FIed style. Signed-off-by: Micha Livne <[email protected]> * 1. Debugging. Signed-off-by: Micha Livne <[email protected]> * 1. Added logging of the number of updated files. Signed-off-by: Micha Livne <[email protected]> Co-authored-by: Micha Livne <[email protected]> Signed-off-by: Paarth Neekhara <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Sep 22, 2021
* 1. Added on-the-fly validation of tarred dataset files. If missing, trying to look for file in same path as metadata file. Signed-off-by: Micha Livne <[email protected]> * 1. FIed style. Signed-off-by: Micha Livne <[email protected]> * 1. Debugging. Signed-off-by: Micha Livne <[email protected]> * 1. Added logging of the number of updated files. Signed-off-by: Micha Livne <[email protected]> Co-authored-by: Micha Livne <[email protected]>
jfsantos
pushed a commit
to jfsantos/NeMo
that referenced
this pull request
Nov 19, 2021
* 1. Added on-the-fly validation of tarred dataset files. If missing, trying to look for file in same path as metadata file. Signed-off-by: Micha Livne <[email protected]> * 1. FIed style. Signed-off-by: Micha Livne <[email protected]> * 1. Debugging. Signed-off-by: Micha Livne <[email protected]> * 1. Added logging of the number of updated files. Signed-off-by: Micha Livne <[email protected]> Co-authored-by: Micha Livne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Adds on-the-fly validation of tarred dataset files.
Changes: