Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge final bugfix r1.3.0 #2749

Merged
merged 20 commits into from
Aug 31, 2021
Merged

Merge final bugfix r1.3.0 #2749

merged 20 commits into from
Aug 31, 2021

Conversation

ericharper
Copy link
Collaborator

No description provided.

ericharper and others added 13 commits August 30, 2021 10:35
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
* Replaced unfold() with split_view()

Signed-off-by: Boris Fomitchev <[email protected]>

* fixed typo

Signed-off-by: Boris Fomitchev <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>
* bugfix

Signed-off-by: Jason <[email protected]>

* bugfix

Signed-off-by: Jason <[email protected]>
Signed-off-by: nithinraok <[email protected]>
Signed-off-by: fayejf <[email protected]>
* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
Signed-off-by: ericharper <[email protected]>
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericharper ericharper merged commit 234e496 into main Aug 31, 2021
@ericharper ericharper deleted the merge_final_bugfix_r1.3.0 branch August 31, 2021 17:52
paarthneekhara pushed a commit to paarthneekhara/NeMo that referenced this pull request Sep 17, 2021
* update jenkins branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* Replaced unfold() with split_view() (NVIDIA#2671)

* Replaced unfold() with split_view()

Signed-off-by: Boris Fomitchev <[email protected]>

* fixed typo

Signed-off-by: Boris Fomitchev <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>

* Fix issues with ASR notebooks (NVIDIA#2698)

Signed-off-by: smajumdar <[email protected]>

* Allow non divisible split_size (NVIDIA#2699)

* bugfix

Signed-off-by: Jason <[email protected]>

* bugfix

Signed-off-by: Jason <[email protected]>

* Fix the feat_out param. (NVIDIA#2714)

* broken link fix (NVIDIA#2720)

Signed-off-by: nithinraok <[email protected]>

* rename (NVIDIA#2721)

Signed-off-by: fayejf <[email protected]>

* apply fix (NVIDIA#2726)

Signed-off-by: Jason <[email protected]>

* [DOCS] Updating adobe and copyright for docs (NVIDIA#2740)

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update notebook branch

Signed-off-by: ericharper <[email protected]>

* update jenkins branch

Signed-off-by: ericharper <[email protected]>

* update jenkins test to use less memory

Signed-off-by: ericharper <[email protected]>

* update jenkins test to use less memory

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Boris Fomitchev <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Vahid Noroozi <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: fayejf <[email protected]>
Signed-off-by: Paarth Neekhara <[email protected]>
jfsantos pushed a commit to jfsantos/NeMo that referenced this pull request Nov 19, 2021
* update jenkins branch

Signed-off-by: ericharper <[email protected]>

* update notebooks branch

Signed-off-by: ericharper <[email protected]>

* Replaced unfold() with split_view() (NVIDIA#2671)

* Replaced unfold() with split_view()

Signed-off-by: Boris Fomitchev <[email protected]>

* fixed typo

Signed-off-by: Boris Fomitchev <[email protected]>

Co-authored-by: Somshubra Majumdar <[email protected]>

* Fix issues with ASR notebooks (NVIDIA#2698)

Signed-off-by: smajumdar <[email protected]>

* Allow non divisible split_size (NVIDIA#2699)

* bugfix

Signed-off-by: Jason <[email protected]>

* bugfix

Signed-off-by: Jason <[email protected]>

* Fix the feat_out param. (NVIDIA#2714)

* broken link fix (NVIDIA#2720)

Signed-off-by: nithinraok <[email protected]>

* rename (NVIDIA#2721)

Signed-off-by: fayejf <[email protected]>

* apply fix (NVIDIA#2726)

Signed-off-by: Jason <[email protected]>

* [DOCS] Updating adobe and copyright for docs (NVIDIA#2740)

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update

Signed-off-by: ericharper <[email protected]>

* update notebook branch

Signed-off-by: ericharper <[email protected]>

* update jenkins branch

Signed-off-by: ericharper <[email protected]>

* update jenkins test to use less memory

Signed-off-by: ericharper <[email protected]>

* update jenkins test to use less memory

Signed-off-by: ericharper <[email protected]>

Co-authored-by: Boris Fomitchev <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Jason <[email protected]>
Co-authored-by: Vahid Noroozi <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
Co-authored-by: fayejf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants