Fix nmt grpc server, concatdataset for raw text files #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MaximumEntropy <[email protected]>
MaximumEntropy
changed the title
…into nmt_bugfixes_and_ci
|
This pull request fixes 2 alerts when merging 96ccd96 into f3a1215 - view on LGTM.com fixed alerts:
|
MaximumEntropy
changed the title
Signed-off-by: MaximumEntropy <[email protected]>
|
This pull request fixes 2 alerts when merging bd6db81 into f3a1215 - view on LGTM.com fixed alerts:
|
Signed-off-by: MaximumEntropy <[email protected]>
|
This pull request fixes 2 alerts when merging 2988f8f into f3a1215 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 2 alerts when merging f1c4052 into 12ab790 - view on LGTM.com fixed alerts:
|
ericharper
pushed a commit
that referenced
this pull request
Aug 24, 2021
* Fix nmt grpc server and concatdataset for raw text files Signed-off-by: MaximumEntropy <[email protected]> * Check if lang direction is provided correctly Signed-off-by: MaximumEntropy <[email protected]> * Style fixes Signed-off-by: MaximumEntropy <[email protected]>
ericharper
added a commit
that referenced
this pull request
Aug 24, 2021
* update jenkins branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update package info Signed-off-by: ericharper <[email protected]> * update readme Signed-off-by: ericharper <[email protected]> * update nemo version for Dockerfile Signed-off-by: ericharper <[email protected]> * update notebook branch Signed-off-by: ericharper <[email protected]> * Update colab links to Transducer notebooks (#2654) Signed-off-by: smajumdar <[email protected]> * Fix nmt grpc server, concatdataset for raw text files (#2656) * Fix nmt grpc server and concatdataset for raw text files Signed-off-by: MaximumEntropy <[email protected]> * Check if lang direction is provided correctly Signed-off-by: MaximumEntropy <[email protected]> * Style fixes Signed-off-by: MaximumEntropy <[email protected]> * add missing init (#2662) Signed-off-by: ekmb <[email protected]> * fix qa inference for single example (#2668) Signed-off-by: Yang Zhang <[email protected]> * Fix max symbol per step updating for RNNT (#2672) * Fix max symbol per step updating for RNNT Signed-off-by: smajumdar <[email protected]> * Fix notebooks Signed-off-by: smajumdar <[email protected]> * Replaced unfold() with split_view() (#2671) * Replaced unfold() with split_view() Signed-off-by: Boris Fomitchev <[email protected]> * fixed typo Signed-off-by: Boris Fomitchev <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> * Correct voice app demo (#2682) Signed-off-by: smajumdar <[email protected]> * Import guard (#2692) * add asr and pynini import guard Signed-off-by: ekmb <[email protected]> * remove asrmodel type Signed-off-by: ekmb <[email protected]> * remove asrmodel type Signed-off-by: ekmb <[email protected]> * fixing branch (#2695) Signed-off-by: Ghasem Pasandi <[email protected]> Co-authored-by: Ghasem Pasandi <[email protected]> * fix for emojis (#2675) * fix for emojis Signed-off-by: ekmb <[email protected]> * remove redundant line Signed-off-by: ekmb <[email protected]> * raise error Signed-off-by: ekmb <[email protected]> * use app_state Signed-off-by: ekmb <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Fix issues with ASR notebooks (#2698) Signed-off-by: smajumdar <[email protected]> * Allow non divisible split_size (#2699) * bugfix Signed-off-by: Jason <[email protected]> * bugfix Signed-off-by: Jason <[email protected]> * TN fix for corner cases (#2689) * serial added, weights to common defaults, decimal bug fix Signed-off-by: ekmb <[email protected]> * one failing Signed-off-by: ekmb <[email protected]> * all tests pass Signed-off-by: ekmb <[email protected]> * remove redundant file Signed-off-by: ekmb <[email protected]> * fix telephone, add test cases Signed-off-by: ekmb <[email protected]> * money fix Signed-off-by: ekmb <[email protected]> * clean format Signed-off-by: ekmb <[email protected]> * fix edge case of greedy decoding for greedy_batch mode (#2701) Signed-off-by: smajumdar <[email protected]> * Remove time macro (#2703) Signed-off-by: smajumdar <[email protected]> * Minor FastPitch Fixes (#2697) * fixes Signed-off-by: Jason <[email protected]> * update CI Signed-off-by: Jason <[email protected]> * refix Signed-off-by: Jason <[email protected]> * Fix ddp error. (#2678) To avoid "MisconfigurationException: Selected distributed backend ddp is not compatible with an interactive environment." error. Co-authored-by: ekmb <[email protected]> * update jenkins Signed-off-by: ericharper <[email protected]> * update notebooks Signed-off-by: ericharper <[email protected]> * add split_view back Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Co-authored-by: Boris Fomitchev <[email protected]> Co-authored-by: Ghasem <[email protected]> Co-authored-by: Ghasem Pasandi <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: khcs <[email protected]> Co-authored-by: ekmb <[email protected]>
paarthneekhara
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Sep 17, 2021
* update jenkins branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update package info Signed-off-by: ericharper <[email protected]> * update readme Signed-off-by: ericharper <[email protected]> * update nemo version for Dockerfile Signed-off-by: ericharper <[email protected]> * update notebook branch Signed-off-by: ericharper <[email protected]> * Update colab links to Transducer notebooks (NVIDIA#2654) Signed-off-by: smajumdar <[email protected]> * Fix nmt grpc server, concatdataset for raw text files (NVIDIA#2656) * Fix nmt grpc server and concatdataset for raw text files Signed-off-by: MaximumEntropy <[email protected]> * Check if lang direction is provided correctly Signed-off-by: MaximumEntropy <[email protected]> * Style fixes Signed-off-by: MaximumEntropy <[email protected]> * add missing init (NVIDIA#2662) Signed-off-by: ekmb <[email protected]> * fix qa inference for single example (NVIDIA#2668) Signed-off-by: Yang Zhang <[email protected]> * Fix max symbol per step updating for RNNT (NVIDIA#2672) * Fix max symbol per step updating for RNNT Signed-off-by: smajumdar <[email protected]> * Fix notebooks Signed-off-by: smajumdar <[email protected]> * Replaced unfold() with split_view() (NVIDIA#2671) * Replaced unfold() with split_view() Signed-off-by: Boris Fomitchev <[email protected]> * fixed typo Signed-off-by: Boris Fomitchev <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> * Correct voice app demo (NVIDIA#2682) Signed-off-by: smajumdar <[email protected]> * Import guard (NVIDIA#2692) * add asr and pynini import guard Signed-off-by: ekmb <[email protected]> * remove asrmodel type Signed-off-by: ekmb <[email protected]> * remove asrmodel type Signed-off-by: ekmb <[email protected]> * fixing branch (NVIDIA#2695) Signed-off-by: Ghasem Pasandi <[email protected]> Co-authored-by: Ghasem Pasandi <[email protected]> * fix for emojis (NVIDIA#2675) * fix for emojis Signed-off-by: ekmb <[email protected]> * remove redundant line Signed-off-by: ekmb <[email protected]> * raise error Signed-off-by: ekmb <[email protected]> * use app_state Signed-off-by: ekmb <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Fix issues with ASR notebooks (NVIDIA#2698) Signed-off-by: smajumdar <[email protected]> * Allow non divisible split_size (NVIDIA#2699) * bugfix Signed-off-by: Jason <[email protected]> * bugfix Signed-off-by: Jason <[email protected]> * TN fix for corner cases (NVIDIA#2689) * serial added, weights to common defaults, decimal bug fix Signed-off-by: ekmb <[email protected]> * one failing Signed-off-by: ekmb <[email protected]> * all tests pass Signed-off-by: ekmb <[email protected]> * remove redundant file Signed-off-by: ekmb <[email protected]> * fix telephone, add test cases Signed-off-by: ekmb <[email protected]> * money fix Signed-off-by: ekmb <[email protected]> * clean format Signed-off-by: ekmb <[email protected]> * fix edge case of greedy decoding for greedy_batch mode (NVIDIA#2701) Signed-off-by: smajumdar <[email protected]> * Remove time macro (NVIDIA#2703) Signed-off-by: smajumdar <[email protected]> * Minor FastPitch Fixes (NVIDIA#2697) * fixes Signed-off-by: Jason <[email protected]> * update CI Signed-off-by: Jason <[email protected]> * refix Signed-off-by: Jason <[email protected]> * Fix ddp error. (NVIDIA#2678) To avoid "MisconfigurationException: Selected distributed backend ddp is not compatible with an interactive environment." error. Co-authored-by: ekmb <[email protected]> * update jenkins Signed-off-by: ericharper <[email protected]> * update notebooks Signed-off-by: ericharper <[email protected]> * add split_view back Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Co-authored-by: Boris Fomitchev <[email protected]> Co-authored-by: Ghasem <[email protected]> Co-authored-by: Ghasem Pasandi <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: khcs <[email protected]> Co-authored-by: ekmb <[email protected]> Signed-off-by: Paarth Neekhara <[email protected]>
jfsantos
pushed a commit
to jfsantos/NeMo
that referenced
this pull request
Nov 19, 2021
* update jenkins branch Signed-off-by: ericharper <[email protected]> * update notebooks branch Signed-off-by: ericharper <[email protected]> * update package info Signed-off-by: ericharper <[email protected]> * update readme Signed-off-by: ericharper <[email protected]> * update nemo version for Dockerfile Signed-off-by: ericharper <[email protected]> * update notebook branch Signed-off-by: ericharper <[email protected]> * Update colab links to Transducer notebooks (NVIDIA#2654) Signed-off-by: smajumdar <[email protected]> * Fix nmt grpc server, concatdataset for raw text files (NVIDIA#2656) * Fix nmt grpc server and concatdataset for raw text files Signed-off-by: MaximumEntropy <[email protected]> * Check if lang direction is provided correctly Signed-off-by: MaximumEntropy <[email protected]> * Style fixes Signed-off-by: MaximumEntropy <[email protected]> * add missing init (NVIDIA#2662) Signed-off-by: ekmb <[email protected]> * fix qa inference for single example (NVIDIA#2668) Signed-off-by: Yang Zhang <[email protected]> * Fix max symbol per step updating for RNNT (NVIDIA#2672) * Fix max symbol per step updating for RNNT Signed-off-by: smajumdar <[email protected]> * Fix notebooks Signed-off-by: smajumdar <[email protected]> * Replaced unfold() with split_view() (NVIDIA#2671) * Replaced unfold() with split_view() Signed-off-by: Boris Fomitchev <[email protected]> * fixed typo Signed-off-by: Boris Fomitchev <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> * Correct voice app demo (NVIDIA#2682) Signed-off-by: smajumdar <[email protected]> * Import guard (NVIDIA#2692) * add asr and pynini import guard Signed-off-by: ekmb <[email protected]> * remove asrmodel type Signed-off-by: ekmb <[email protected]> * remove asrmodel type Signed-off-by: ekmb <[email protected]> * fixing branch (NVIDIA#2695) Signed-off-by: Ghasem Pasandi <[email protected]> Co-authored-by: Ghasem Pasandi <[email protected]> * fix for emojis (NVIDIA#2675) * fix for emojis Signed-off-by: ekmb <[email protected]> * remove redundant line Signed-off-by: ekmb <[email protected]> * raise error Signed-off-by: ekmb <[email protected]> * use app_state Signed-off-by: ekmb <[email protected]> Co-authored-by: Eric Harper <[email protected]> * Fix issues with ASR notebooks (NVIDIA#2698) Signed-off-by: smajumdar <[email protected]> * Allow non divisible split_size (NVIDIA#2699) * bugfix Signed-off-by: Jason <[email protected]> * bugfix Signed-off-by: Jason <[email protected]> * TN fix for corner cases (NVIDIA#2689) * serial added, weights to common defaults, decimal bug fix Signed-off-by: ekmb <[email protected]> * one failing Signed-off-by: ekmb <[email protected]> * all tests pass Signed-off-by: ekmb <[email protected]> * remove redundant file Signed-off-by: ekmb <[email protected]> * fix telephone, add test cases Signed-off-by: ekmb <[email protected]> * money fix Signed-off-by: ekmb <[email protected]> * clean format Signed-off-by: ekmb <[email protected]> * fix edge case of greedy decoding for greedy_batch mode (NVIDIA#2701) Signed-off-by: smajumdar <[email protected]> * Remove time macro (NVIDIA#2703) Signed-off-by: smajumdar <[email protected]> * Minor FastPitch Fixes (NVIDIA#2697) * fixes Signed-off-by: Jason <[email protected]> * update CI Signed-off-by: Jason <[email protected]> * refix Signed-off-by: Jason <[email protected]> * Fix ddp error. (NVIDIA#2678) To avoid "MisconfigurationException: Selected distributed backend ddp is not compatible with an interactive environment." error. Co-authored-by: ekmb <[email protected]> * update jenkins Signed-off-by: ericharper <[email protected]> * update notebooks Signed-off-by: ericharper <[email protected]> * add split_view back Signed-off-by: ericharper <[email protected]> Co-authored-by: Somshubra Majumdar <[email protected]> Co-authored-by: Sandeep Subramanian <[email protected]> Co-authored-by: Evelina <[email protected]> Co-authored-by: Yang Zhang <[email protected]> Co-authored-by: Boris Fomitchev <[email protected]> Co-authored-by: Ghasem <[email protected]> Co-authored-by: Ghasem Pasandi <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: khcs <[email protected]> Co-authored-by: ekmb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes