Changes for ONNX conversion of Conformer models #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jbalam-nv
commented
Jul 2, 2021
jbalam-nv
commented
- Brought in the needed changes from Vahid's earlier PR: https://github.com/NVIDIA/NeMo/pull/2359/files
- Tested conversion with scripts/export/convasr_to_single_onnx.py
- Tested the converted large, medium and small models with dev-clean and WER is very close (within 0.01%) of correspondiong .nemo models
titu1994
reviewed
Jul 3, 2021
…, onnx support was added in pytorch 1.8 Signed-off-by: jbalam <[email protected]>
Reverted these changes as onnx conversion of nn.silu is now supported in pytorch |
Signed-off-by: jbalam <[email protected]>
pasandi20
pushed a commit
to pasandi20/NeMo
that referenced
this pull request
Jul 13, 2021
* Changes to suport onnx conversion of conformenr models Signed-off-by: jbalam <[email protected]> * reverting changes to silu activation as this is not an issue anymore, onnx support was added in pytorch 1.8 Signed-off-by: jbalam <[email protected]> * style fix Signed-off-by: jbalam <[email protected]> Signed-off-by: Ghasem Pasandi <[email protected]>
fayejf
pushed a commit
that referenced
this pull request
Jul 16, 2021
* Changes to suport onnx conversion of conformenr models Signed-off-by: jbalam <[email protected]> * reverting changes to silu activation as this is not an issue anymore, onnx support was added in pytorch 1.8 Signed-off-by: jbalam <[email protected]> * style fix Signed-off-by: jbalam <[email protected]>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Jul 20, 2021
* Changes to suport onnx conversion of conformenr models Signed-off-by: jbalam <[email protected]> * reverting changes to silu activation as this is not an issue anymore, onnx support was added in pytorch 1.8 Signed-off-by: jbalam <[email protected]> * style fix Signed-off-by: jbalam <[email protected]>
paarthneekhara
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Sep 17, 2021
* Changes to suport onnx conversion of conformenr models Signed-off-by: jbalam <[email protected]> * reverting changes to silu activation as this is not an issue anymore, onnx support was added in pytorch 1.8 Signed-off-by: jbalam <[email protected]> * style fix Signed-off-by: jbalam <[email protected]> Signed-off-by: Paarth Neekhara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.