Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add coverage reports #11912

Merged
merged 19 commits into from
Jan 28, 2025
Merged

ci: Add coverage reports #11912

merged 19 commits into from
Jan 28, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jan 21, 2025

What does this PR do ?

This PR generates coverage reports for unit tests. So far, these reports are only visible inside the pipeline. In a future PR, we will postprocess and render these properly.

This PR also touches some other CI parts:

  • Proper import tests for important domains
  • Rename of cicd-container-setup step so that it better reflects its purpose
  • Move tests to single-GPU if appropriate

Passing pipeline: https://github.com/NVIDIA/NeMo/actions/runs/13011140459

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label Jan 21, 2025
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 21, 2025
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/unit-test-coverage branch from 5e1de62 to 2aaf465 Compare January 27, 2025 23:33
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 27, 2025
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 28, 2025
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g force-pushed the ko3n1g/ci/unit-test-coverage branch from 42ba160 to e933f56 Compare January 28, 2025 10:45
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 28, 2025
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 28, 2025
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 28, 2025
@ko3n1g ko3n1g marked this pull request as ready for review January 28, 2025 14:58
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner January 28, 2025 14:58
Copy link
Contributor

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g merged commit f67eef6 into main Jan 28, 2025
206 of 208 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/unit-test-coverage branch January 28, 2025 15:21
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
Prepare for coverage reports

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Abhinav Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants