Bugfix for output_generation_logits in tensorrtllm #11820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[🤖]: Hi @athitten 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
oyilmaz-nvidia
approved these changes
Jan 11, 2025
janekl
pushed a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Abhishree <[email protected]>
8 tasks
janekl
pushed a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Abhishree <[email protected]> Signed-off-by: Jan Lasek <[email protected]>
janekl
added a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Abhishree <[email protected]> Signed-off-by: Jan Lasek <[email protected]> Co-authored-by: Abhishree Thittenamane <[email protected]>
pablo-garay
pushed a commit
that referenced
this pull request
Jan 16, 2025
) * Revert "Revert Mcore update since it caused regression (#11791)" This reverts commit 84b2bf0. * Fix Gemma2 Attention init args (#11792) * Use _get_mlp_module_spec from Megatron Core rather than redefine locally (#11834) * Use _get_mlp_module_spec from MCore rather than redefine Signed-off-by: Jan Lasek <[email protected]> * Apply isort and black reformatting Signed-off-by: janekl <[email protected]> * Update nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py Co-authored-by: oliver könig <[email protected]> Signed-off-by: Jan Lasek <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]> Signed-off-by: janekl <[email protected]> Co-authored-by: janekl <[email protected]> Co-authored-by: oliver könig <[email protected]> * Bugfix for output_generation_logits in tensorrtllm (#11820) (#11833) Signed-off-by: Abhishree <[email protected]> Signed-off-by: Jan Lasek <[email protected]> Co-authored-by: Abhishree Thittenamane <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]> Signed-off-by: janekl <[email protected]> Signed-off-by: Abhishree <[email protected]> Co-authored-by: Ao Tang <[email protected]> Co-authored-by: Jan Lasek <[email protected]> Co-authored-by: janekl <[email protected]> Co-authored-by: Abhishree Thittenamane <[email protected]>
abhinavg4
pushed a commit
that referenced
this pull request
Jan 30, 2025
Signed-off-by: Abhishree <[email protected]> Signed-off-by: Abhinav Garg <[email protected]>
abhinavg4
pushed a commit
that referenced
this pull request
Jan 30, 2025
) * Revert "Revert Mcore update since it caused regression (#11791)" This reverts commit 84b2bf0. * Fix Gemma2 Attention init args (#11792) * Use _get_mlp_module_spec from Megatron Core rather than redefine locally (#11834) * Use _get_mlp_module_spec from MCore rather than redefine Signed-off-by: Jan Lasek <[email protected]> * Apply isort and black reformatting Signed-off-by: janekl <[email protected]> * Update nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py Co-authored-by: oliver könig <[email protected]> Signed-off-by: Jan Lasek <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]> Signed-off-by: janekl <[email protected]> Co-authored-by: janekl <[email protected]> Co-authored-by: oliver könig <[email protected]> * Bugfix for output_generation_logits in tensorrtllm (#11820) (#11833) Signed-off-by: Abhishree <[email protected]> Signed-off-by: Jan Lasek <[email protected]> Co-authored-by: Abhishree Thittenamane <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]> Signed-off-by: janekl <[email protected]> Signed-off-by: Abhishree <[email protected]> Co-authored-by: Ao Tang <[email protected]> Co-authored-by: Jan Lasek <[email protected]> Co-authored-by: janekl <[email protected]> Co-authored-by: Abhishree Thittenamane <[email protected]> Signed-off-by: Abhinav Garg <[email protected]>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
Signed-off-by: Abhishree <[email protected]> Signed-off-by: Youngeun Kwon <[email protected]>
youngeunkwon0405
pushed a commit
to youngeunkwon0405/NeMo
that referenced
this pull request
Feb 10, 2025
NVIDIA#11799) * Revert "Revert Mcore update since it caused regression (NVIDIA#11791)" This reverts commit 84b2bf0. * Fix Gemma2 Attention init args (NVIDIA#11792) * Use _get_mlp_module_spec from Megatron Core rather than redefine locally (NVIDIA#11834) * Use _get_mlp_module_spec from MCore rather than redefine Signed-off-by: Jan Lasek <[email protected]> * Apply isort and black reformatting Signed-off-by: janekl <[email protected]> * Update nemo/collections/nlp/models/language_modeling/megatron/gpt_layer_modelopt_spec.py Co-authored-by: oliver könig <[email protected]> Signed-off-by: Jan Lasek <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]> Signed-off-by: janekl <[email protected]> Co-authored-by: janekl <[email protected]> Co-authored-by: oliver könig <[email protected]> * Bugfix for output_generation_logits in tensorrtllm (NVIDIA#11820) (NVIDIA#11833) Signed-off-by: Abhishree <[email protected]> Signed-off-by: Jan Lasek <[email protected]> Co-authored-by: Abhishree Thittenamane <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]> Signed-off-by: janekl <[email protected]> Signed-off-by: Abhishree <[email protected]> Co-authored-by: Ao Tang <[email protected]> Co-authored-by: Jan Lasek <[email protected]> Co-authored-by: janekl <[email protected]> Co-authored-by: Abhishree Thittenamane <[email protected]> Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Gets the value of
generation_logits_availablefrominputs["output_generation_logits"][0][0]so that it is a bool as opposed toinputs["output_generation_logits"]where it's a np array and can give error when the array is len > 1.Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information