Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mcore #11740

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Bump mcore #11740

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61ce143
chore(beep boop 🤖): Bump `MCORE_TAG=076972e...` (2025-01-03)
pablo-garay Jan 3, 2025
2797fc1
Support attention backend configuration changes (#11517)
ananthsub Jan 3, 2025
778ea30
Some fixes to bump mcore (#11600)
ko3n1g Jan 3, 2025
cec9eb6
Use empty dict instead of none to load only metadata from dist ckpt
cuichenx Jan 6, 2025
903044c
remove mcore-inserted env vars
akoumpa Jan 7, 2025
159d8d4
Apply isort and black reformatting
akoumpa Jan 7, 2025
47e57b2
Add raising=False for delenv
athitten Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/collections/llm/gpt/model/test_model_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

import torch

import os
torch.set_grad_enabled(False)


Expand Down Expand Up @@ -95,5 +95,8 @@ def import_from_hf(config_name, hf_path):

if __name__ == '__main__':
for config_name, hf_id in config_name_to_hf_id.items():
for env_var in ['NVTE_FLASH_ATTN', 'NVTE_FUSED_ATTN', 'NVTE_UNFUSED_ATTN']:
if env_var in os.environ:
del os.environ[env_var]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our of curiosity: where are the vars set?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it happens inside megatron, there's no automatic cleanup of the env-vars set in check_and_set_env_variable, therefore I'm doing it manually here.

src = f'hf:///home/TestData/nemo2_ckpt/{config_name}'
import_from_hf(config_name, src)
Loading