Downgrading the 'datasets' package from 3.0.0 to 2.21.0 for Multilang_ASR.ipynb and ASR_CTC_Language_Finetuning.ipynb #11675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
'datasets' recently released the latest version
3.0.0
on Sep 11th, but some HF datasets (e.g., MCV 3.0, MCV 6.1) do not update their code for the latest version. Attempting to download these MCV datasets using datasets3.0.0
results in the following error:TypeError: DownloadConfig.__init__() got an unexpected keyword argument 'ignore_url_params'.
As a workaround, we need to downgrade the datasets package to version
2.21.0
in some tutorial notebooks. Please check the first block of each notebook for this change.Collection: [Note which collection this PR will affect]
NeMo/tutorial/asr
Changelog
Adding
!pip install datasets==2.21.0
in the first block of each tutorial.GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
Although unrelated to this PR, I wanted to highlight an issue encountered when calling Trainer.test() multiple times. In the
Multilang_ASR.ipynb
notebook, this sometimes results in aRuntimeError: CUDA error: an illegal memory access was encountered
error in certain containers with specific PyTorch versions. This behavior has been verified in containers24.06
and24.12-rc0
(nvcr.io/nvidia/nemo:24.12-rc0
), though it does not occur consistently and does not appear in other containers like24.05
(nvcr.io/nvidia/nemo:24.05
). A similar issue has been documented here with the24.06
container (nvcr.io/nvidia/pytorch:24.06-py3
). Testing is ongoing, but the root cause has not yet been identified.