Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test install on macos #11429

Merged
merged 4 commits into from
Jan 8, 2025
Merged

ci: Test install on macos #11429

merged 4 commits into from
Jan 8, 2025

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 28, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g requested a review from pablo-garay as a code owner November 28, 2024 08:49
@github-actions github-actions bot added the CI label Nov 28, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/macos-install branch from dfcfd4c to 6f76280 Compare December 6, 2024 09:17
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/macos-install branch from 30a4e28 to 976e8ec Compare December 18, 2024 08:58
@github-actions github-actions bot added the NLP label Dec 18, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2025

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 2, 2025
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/macos-install branch from 45dd4ee to 44ce5b5 Compare January 8, 2025 09:30
@github-actions github-actions bot removed the NLP label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module setup
setup.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)
setup.py:72:0: C0116: Missing function or method docstring (missing-function-docstring)
setup.py:142:0: C0115: Missing class docstring (missing-class-docstring)

-----------------------------------
Your code has been rated at 9.64/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@ko3n1g ko3n1g force-pushed the ko3n1g/ci/macos-install branch from 1d280be to d17775d Compare January 8, 2025 09:46
@ko3n1g ko3n1g added Run CICD and removed stale labels Jan 8, 2025
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/macos-install branch from ec4b670 to 862b32e Compare January 8, 2025 09:48
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 8, 2025
ko3n1g added 4 commits January 8, 2025 11:57
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
Signed-off-by: oliver könig <[email protected]>
f
Signed-off-by: oliver könig <[email protected]>
@ko3n1g ko3n1g force-pushed the ko3n1g/ci/macos-install branch from db9d8f2 to 8e421c6 Compare January 8, 2025 10:57
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

[🤖]: Hi @ko3n1g 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@ko3n1g ko3n1g merged commit e04e345 into main Jan 8, 2025
198 of 201 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/macos-install branch January 8, 2025 17:20
pablo-garay added a commit that referenced this pull request Jan 8, 2025
pablo-garay added a commit that referenced this pull request Jan 9, 2025
* Revert "ci: Test install on macos (#11429)"

This reverts commit e04e345.

* Revert "chore(beep boop 🤖): Bump `MCORE_TAG=4dc8977...` (2025-01-07) (#11768)"

This reverts commit 06cf0dd.

* Revert "Bump mcore (#11740)"

This reverts commit 8b9d6c7.
BoxiangW pushed a commit that referenced this pull request Jan 14, 2025
* Revert "ci: Test install on macos (#11429)"

This reverts commit e04e345.

* Revert "chore(beep boop 🤖): Bump `MCORE_TAG=4dc8977...` (2025-01-07) (#11768)"

This reverts commit 06cf0dd.

* Revert "Bump mcore (#11740)"

This reverts commit 8b9d6c7.
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* ci: Test install on macos

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* fix

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Abhinav Garg <[email protected]>
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* Revert "ci: Test install on macos (#11429)"

This reverts commit e04e345.

* Revert "chore(beep boop 🤖): Bump `MCORE_TAG=4dc8977...` (2025-01-07) (#11768)"

This reverts commit 06cf0dd.

* Revert "Bump mcore (#11740)"

This reverts commit 8b9d6c7.

Signed-off-by: Abhinav Garg <[email protected]>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* ci: Test install on macos

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

* fix

Signed-off-by: oliver könig <[email protected]>

* f

Signed-off-by: oliver könig <[email protected]>

---------

Signed-off-by: oliver könig <[email protected]>
Signed-off-by: Youngeun Kwon <[email protected]>
youngeunkwon0405 pushed a commit to youngeunkwon0405/NeMo that referenced this pull request Feb 10, 2025
* Revert "ci: Test install on macos (NVIDIA#11429)"

This reverts commit e04e345.

* Revert "chore(beep boop 🤖): Bump `MCORE_TAG=4dc8977...` (2025-01-07) (NVIDIA#11768)"

This reverts commit 06cf0dd.

* Revert "Bump mcore (NVIDIA#11740)"

This reverts commit 8b9d6c7.

Signed-off-by: Youngeun Kwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant