Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PTQ tests and ModelOpt version #11095

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Update PTQ tests and ModelOpt version #11095

merged 4 commits into from
Oct 30, 2024

Conversation

janekl
Copy link
Collaborator

@janekl janekl commented Oct 30, 2024

What does this PR do ?

  1. Deprecating Nemo 1 PTQ tests except FP8
  2. Updating Nemo 1 FP8 PTQ test to use an up-to-date converted Llama 2 model
  3. Bumping modelopt to 0.19.0

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@github-actions github-actions bot added the CI label Oct 30, 2024
@janekl janekl enabled auto-merge (squash) October 30, 2024 09:34
Copy link
Contributor

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@janekl janekl added Run CICD and removed Run CICD labels Oct 30, 2024
Copy link
Collaborator

@ko3n1g ko3n1g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

[🤖]: Hi @janekl 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@janekl janekl merged commit b9f627f into main Oct 30, 2024
156 of 157 checks passed
@janekl janekl deleted the jlasek/ptq_updates branch October 30, 2024 18:08
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Deprecate NeMo 1 PTQ tests except FP8

Signed-off-by: Jan Lasek <[email protected]>

* Convert model right before testing it for FP8 PTQ

Signed-off-by: Jan Lasek <[email protected]>

* Bump modelopt version

Signed-off-by: Jan Lasek <[email protected]>

---------

Signed-off-by: Jan Lasek <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
lilyw97 pushed a commit to lilyw97/NeMo that referenced this pull request Nov 13, 2024
* Deprecate NeMo 1 PTQ tests except FP8

Signed-off-by: Jan Lasek <[email protected]>

* Convert model right before testing it for FP8 PTQ

Signed-off-by: Jan Lasek <[email protected]>

* Bump modelopt version

Signed-off-by: Jan Lasek <[email protected]>

---------

Signed-off-by: Jan Lasek <[email protected]>
HuiyingLi pushed a commit to HuiyingLi/NeMo that referenced this pull request Nov 15, 2024
* Deprecate NeMo 1 PTQ tests except FP8

Signed-off-by: Jan Lasek <[email protected]>

* Convert model right before testing it for FP8 PTQ

Signed-off-by: Jan Lasek <[email protected]>

* Bump modelopt version

Signed-off-by: Jan Lasek <[email protected]>

---------

Signed-off-by: Jan Lasek <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Deprecate NeMo 1 PTQ tests except FP8

Signed-off-by: Jan Lasek <[email protected]>

* Convert model right before testing it for FP8 PTQ

Signed-off-by: Jan Lasek <[email protected]>

* Bump modelopt version

Signed-off-by: Jan Lasek <[email protected]>

---------

Signed-off-by: Jan Lasek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants