Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for fp8 trt-llm export #10444

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

Laplasjan107
Copy link
Collaborator

What does this PR do ?

Update documentation for fp8 trt-llm export

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Piotr Kamiński <[email protected]>
@github-actions github-actions bot added the NLP label Sep 10, 2024
Signed-off-by: Piotr Kamiński <[email protected]>
@janekl janekl merged commit 308eaac into NVIDIA:main Sep 17, 2024
199 of 296 checks passed
ko3n1g pushed a commit that referenced this pull request Sep 17, 2024
* Update doc for fp8 trt-llm export

Signed-off-by: Piotr Kamiński <[email protected]>

* Apply review suggestions

Signed-off-by: Piotr Kamiński <[email protected]>

* code review 

Signed-off-by: Piotr Kamiński <[email protected]>

---------

Signed-off-by: Piotr Kamiński <[email protected]>
ko3n1g added a commit that referenced this pull request Sep 18, 2024
* Update doc for fp8 trt-llm export



* Apply review suggestions



* code review 



---------

Signed-off-by: Piotr Kamiński <[email protected]>
Co-authored-by: Piotr Kamiński <[email protected]>
akoumpa pushed a commit that referenced this pull request Sep 18, 2024
* Update doc for fp8 trt-llm export

* Apply review suggestions

* code review

---------

Signed-off-by: Piotr Kamiński <[email protected]>
Co-authored-by: Piotr Kamiński <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
gwarmstrong pushed a commit to gwarmstrong/NeMo that referenced this pull request Sep 19, 2024
* Update doc for fp8 trt-llm export

Signed-off-by: Piotr Kamiński <[email protected]>

* Apply review suggestions

Signed-off-by: Piotr Kamiński <[email protected]>

* code review 

Signed-off-by: Piotr Kamiński <[email protected]>

---------

Signed-off-by: Piotr Kamiński <[email protected]>
Signed-off-by: George Armstrong <[email protected]>
akoumpa pushed a commit that referenced this pull request Sep 23, 2024
* Update doc for fp8 trt-llm export

* Apply review suggestions

* code review

---------

Signed-off-by: Piotr Kamiński <[email protected]>
Co-authored-by: Piotr Kamiński <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Update doc for fp8 trt-llm export

Signed-off-by: Piotr Kamiński <[email protected]>

* Apply review suggestions

Signed-off-by: Piotr Kamiński <[email protected]>

* code review 

Signed-off-by: Piotr Kamiński <[email protected]>

---------

Signed-off-by: Piotr Kamiński <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* Update doc for fp8 trt-llm export

Signed-off-by: Piotr Kamiński <[email protected]>

* Apply review suggestions

Signed-off-by: Piotr Kamiński <[email protected]>

* code review

Signed-off-by: Piotr Kamiński <[email protected]>

---------

Signed-off-by: Piotr Kamiński <[email protected]>
Signed-off-by: Lifu Zhang <[email protected]>
tomlifu pushed a commit to tomlifu/NeMo that referenced this pull request Oct 25, 2024
* Update doc for fp8 trt-llm export

Signed-off-by: Piotr Kamiński <[email protected]>

* Apply review suggestions

Signed-off-by: Piotr Kamiński <[email protected]>

* code review

Signed-off-by: Piotr Kamiński <[email protected]>

---------

Signed-off-by: Piotr Kamiński <[email protected]>
Signed-off-by: Lifu Zhang <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
* Update doc for fp8 trt-llm export

Signed-off-by: Piotr Kamiński <[email protected]>

* Apply review suggestions

Signed-off-by: Piotr Kamiński <[email protected]>

* code review 

Signed-off-by: Piotr Kamiński <[email protected]>

---------

Signed-off-by: Piotr Kamiński <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
XuesongYang pushed a commit to paarthneekhara/NeMo that referenced this pull request Jan 18, 2025
* Update doc for fp8 trt-llm export

Signed-off-by: Piotr Kamiński <[email protected]>

* Apply review suggestions

Signed-off-by: Piotr Kamiński <[email protected]>

* code review 

Signed-off-by: Piotr Kamiński <[email protected]>

---------

Signed-off-by: Piotr Kamiński <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants