Skip to content

Commit

Permalink
deprecation warning (#7193)
Browse files Browse the repository at this point in the history
* dep warning

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* added logging import

Signed-off-by: arendu <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* import fix

Signed-off-by: arendu <[email protected]>

* pretty deprecation warning

Signed-off-by: arendu <[email protected]>

---------

Signed-off-by: arendu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
arendu and pre-commit-ci[bot] committed Aug 14, 2023
1 parent 4833347 commit e676a15
Show file tree
Hide file tree
Showing 7 changed files with 41 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,10 @@ def main(cfg) -> None:


if __name__ == '__main__':
dep_msg = "* Please switch to using examples/nlp/language_modeling/tuning/megatron_gpt_peft_tuning.py *"
dep = "Deprecation Notice!!".center(len(dep_msg) - 2, " ")
banner = "*" * len(dep_msg)
spacer = " " * (len(dep_msg) - 2)
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
main()
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from nemo.collections.nlp.modules.common.transformer.text_generation import LengthParam, SamplingParam
from nemo.collections.nlp.parts.nlp_overrides import NLPDDPStrategy, NLPSaveRestoreConnector
from nemo.core.config import hydra_runner
from nemo.utils import logging

mp.set_start_method("spawn", force=True)

Expand Down Expand Up @@ -194,4 +195,10 @@ def placeholder():


if __name__ == '__main__':
dep_msg = "* Please switch to using examples/nlp/language_modeling/tuning/megatron_gpt_peft_eval.py *"
dep = "Deprecation Notice!!".center(len(dep_msg) - 2, " ")
banner = "*" * len(dep_msg)
spacer = " " * (len(dep_msg) - 2)
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
main()
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from nemo.collections.nlp.models.language_modeling.megatron_gpt_model import MegatronGPTModel
from nemo.collections.nlp.parts.nlp_overrides import NLPDDPStrategy, NLPSaveRestoreConnector
from nemo.core.config import hydra_runner
from nemo.utils import logging

mp.set_start_method("spawn", force=True)

Expand Down Expand Up @@ -147,4 +148,10 @@ def dummy():


if __name__ == '__main__':
dep_msg = "* Please switch to using examples/nlp/language_modeling/tuning/megatron_gpt_peft_eval.py *"
dep = "Deprecation Notice!!".center(len(dep_msg) - 2, " ")
banner = "*" * len(dep_msg)
spacer = " " * (len(dep_msg) - 2)
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
main() # noqa pylint: disable=no-value-for-parameter
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,10 @@ def main(cfg) -> None:


if __name__ == '__main__':
dep_msg = "* Please switch to using examples/nlp/language_modeling/tuning/megatron_gpt_peft_tuning.py *"
dep = "Deprecation Notice!!".center(len(dep_msg) - 2, " ")
banner = "*" * len(dep_msg)
spacer = " " * (len(dep_msg) - 2)
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
main()
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
from nemo.collections.nlp.parts.nlp_overrides import NLPDDPStrategy, NLPSaveRestoreConnector
from nemo.core.config import hydra_runner

from nemo.utils import logging

mp.set_start_method("spawn", force=True)

"""
Expand Down Expand Up @@ -145,4 +147,10 @@ def dummy():


if __name__ == '__main__':
dep_msg = "* Please switch to using examples/nlp/language_modeling/tuning/megatron_gpt_peft_eval.py *"
dep = "Deprecation Notice!!".center(len(dep_msg) - 2, " ")
banner = "*" * len(dep_msg)
spacer = " " * (len(dep_msg) - 2)
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
main() # noqa pylint: disable=no-value-for-parameter
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,10 @@ def main(cfg) -> None:


if __name__ == '__main__':
dep_msg = "* Please switch to using examples/nlp/language_modeling/tuning/megatron_gpt_peft_tuning.py *"
dep = "Deprecation Notice!!".center(len(dep_msg) - 2, " ")
banner = "*" * len(dep_msg)
spacer = " " * (len(dep_msg) - 2)
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
main()
logging.warning(f"\n\n{banner}\n*{spacer}*\n*{dep}*\n{dep_msg}\n*{spacer}*\n{banner}\n\n")
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def init_model(self, cfg: DictConfig, trainer: Trainer):
with open_dict(self.cfg):
self.cfg.existing_tasks = (
self.existing_tasks + self.new_tasks
) # TODO: for backward compatibility (@adithyare) in general these tasks lists should be depricated
) # TODO: for backward compatibility (@adithyare) in general these tasks lists should be deprecated

self.virtual_prompt_style = VirtualPromptStyle(cfg.virtual_prompt_style)
self.model_type = ModelType.encoder_or_decoder
Expand Down

0 comments on commit e676a15

Please sign in to comment.