Replace type with isinstance

Signed-off-by: Abhishree <[email protected]>
NVIDIA · Sep 29, 2023 · af78882 · af78882
1 parent 3952c68
commit af78882
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/nemo/collections/asr/models/enhancement_models.py b/nemo/collections/asr/models/enhancement_models.py
@@ -435,12 +435,12 @@ def evaluation_step(self, batch, batch_idx, dataloader_idx: int = 0, tag: str =
         self.log('global_step', torch.tensor(self.trainer.global_step, dtype=torch.float32), sync_dist=True)
 
         if tag == 'val':
-            if type(self.trainer.val_dataloaders) == list and len(self.trainer.val_dataloaders) > 1:
+            if isinstance(self.trainer.val_dataloaders, (list, tuple)) and len(self.trainer.val_dataloaders) > 1:
                 self.validation_step_outputs[dataloader_idx].append(output_dict)
             else:
                 self.validation_step_outputs.append(output_dict)
         else:
-            if type(self.trainer.test_dataloaders) == list and len(self.trainer.test_dataloaders) > 1:
+            if isinstance(self.trainer.test_dataloaders, (list, tuple)) and len(self.trainer.test_dataloaders) > 1:
                 self.test_step_outputs[dataloader_idx].append(output_dict)
             else:
                 self.test_step_outputs.append(output_dict)

diff --git a/nemo/collections/asr/models/label_models.py b/nemo/collections/asr/models/label_models.py
@@ -381,12 +381,12 @@ def evaluation_step(self, batch, batch_idx, dataloader_idx: int = 0, tag: str =
             f'{tag}_acc_macro_stats': stats,
         }
         if tag == 'val':
-            if type(self.trainer.val_dataloaders) == list and len(self.trainer.val_dataloaders) > 1:
+            if isinstance(self.trainer.val_dataloaders, (list, tuple)) and len(self.trainer.val_dataloaders) > 1:
                 self.validation_step_outputs[dataloader_idx].append(output)
             else:
                 self.validation_step_outputs.append(output)
         else:
-            if type(self.trainer.test_dataloaders) == list and len(self.trainer.test_dataloaders) > 1:
+            if isinstance(self.trainer.test_dataloaders, (list, tuple)) and len(self.trainer.test_dataloaders) > 1:
                 self.test_step_outputs[dataloader_idx].append(output)
             else:
                 self.test_step_outputs.append(output)