fix: prevent plugin config masking by willkill07 · Pull Request #626 · NVIDIA/NeMo-Relay

willkill07 · 2026-08-01T00:09:37Z

Overview

Reject unsupported top-level plugins.toml schema versions before configuration layering can mask them, including when Relay is initialized as a library.

I confirm this contribution is my own work, or I have the right to submit it under this project's license.
I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

Validate every discovered plugin configuration file's top-level version before merging higher-precedence files or programmatic configuration.
Preserve discovered enabled and policy values when the typed library configuration only contains serde defaults.
Continue applying non-default programmatic values and merging component config bodies.
Update CLI, FFI, and Go fixtures that previously relied on invalid versions being masked.
Add regression coverage for masked versions, inherited defaults, and non-default overrides.

This does not change public API signatures and has no breaking changes.

Validation included Rust formatting and linting, pre-commit, focused regression tests, and the Rust, Python, Node.js, and Go test suites. Four unrelated environment-sensitive CLI process tests fail locally because they discover installed user plugins or launch the real Codex binary.

Where should the reviewer start?

Start with crates/core/src/plugin.rs, particularly resolve_plugin_config, plugin_config_overlay_value, and merge_plugin_config_documents, then review the regression cases in crates/core/tests/unit/plugin_tests.rs.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Relates to: none

Summary by CodeRabbit

Bug Fixes
- Improved plugin configuration layering so discovered settings are preserved unless explicitly overridden.
- Added validation for configuration schema versions, with clear errors for invalid or unsupported versions.
- Ensured plugin configuration precedence consistently selects the intended override file.
- Preserved explicitly configured policy and component settings while applying file-based defaults.
Tests
- Expanded coverage for configuration inheritance, overrides, precedence, and version validation.
- Updated plugin activation scenarios to use valid configuration versions.

Signed-off-by: Will Killian <wkillian@nvidia.com>

coderabbitai · 2026-08-01T00:09:53Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 78d5b290-fb35-4da9-bc26-8f46385ba03b

📥 Commits

Reviewing files that changed from the base of the PR and between a363419 and 60a677b.

📒 Files selected for processing (1)

crates/cli/tests/coverage/shared/config_tests.rs

📜 Recent review details

⏰ Context from checks skipped due to timeout. (2)

GitHub Check: Preview docs
GitHub Check: Check / Run

🧰 Additional context used

📓 Path-based instructions (9)

**/*.rs

📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)

**/*.rs: Any Rust change must run just test-rust
Any Rust change must run cargo fmt --all
Any Rust change must run cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all for all FFI work since it is Rust work
Run just test-rust to validate FFI changes
Run cargo clippy --workspace --all-targets -- -D warnings to enforce strict linting on FFI work

When Rust files changed as part of Go work, also run cargo fmt --all, just test-rust, and cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all when Rust files are changed as part of Node work
Run cargo clippy --workspace --all-targets -- -D warnings when Rust files are changed as part of Node work
Run just test-rust when Rust files are changed as part of Node work

When changing the core Rust runtime or Rust-facing API surface, format Rust code with cargo fmt (rustfmt defaults), keep cargo clippy -- -D warnings clean, and satisfy cargo deny check per deny.toml.

**/*.rs: If any Rust code changed, always run just test-rust.
If any Rust code changed, also run cargo fmt --all.
If any Rust code changed, also run cargo clippy --workspace --all-targets -- -D warnings.
For Rust changes headed for review, run cargo fmt --all and cargo clippy --workspace --all-targets -- -D warnings even if relying on pre-commit.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

**/*.{rs,py}

📄 CodeRabbit inference engine (AGENTS.md)

Follow binding naming conventions in Rust and Python: use snake_case.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

**/*.{rs,py,js,mjs,cjs,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{rs,py,js,mjs,cjs,ts,tsx}: Use Json = serde_json::Value in Rust-facing runtime APIs where the existing code expects JSON payloads.
Use Result<T> with FlowError in core runtime paths, and keep errors explicit and binding-appropriate at the wrapper layer.
Keep async behavior on the existing tokio-based model; bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

**/*.{rs,py,go,js,ts,c,h}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Use language-appropriate naming conventions: Rust snake_case, C FFI exports prefixed nemo_relay_, Go PascalCase, Node.js camelCase, and Python snake_case.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

**/*.{rs,go,js,ts}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Add the SPDX license header to all Rust, Go, JavaScript, and TypeScript source files using the corresponding // comment form.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

**/*

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

**/*: Format changed files with the language-native formatter before the final lint/test pass.
If dynamic plugin behavior changed, use maintain-dynamic-plugins and include the native SDK, worker protocol, Python SDK, docs, packaging, and Codecov surfaces in the validation plan.
If code changes alter APIs, bindings, commands, paths, packaging behavior, observability/adaptive semantics, or documented best practices, update any dependent maintainer or consumer skills in the same branch.
During iteration, prefer uv run pre-commit run --files <changed files...>.
Before review or handoff, run uv run pre-commit run --all-files.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

**/*.{rs,py,go,js,ts}

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

If a language surface changed, always run that language's test target even when Rust core did not change.

**/*.{rs,py,go,js,ts}: When observability configuration or lifecycle is exposed, keep FFI and Python, Go, and Node.js binding-native config objects and subscriber/exporter methods aligned in logical knobs and semantics.
Require every OpenTelemetry endpoint to have a type and nonblank destination; resolve header_env values at activation and reject missing, blank, or duplicate headers.
Concatenate layered ATOF sink, ATIF storage, and OpenTelemetry endpoint lists with higher-precedence entries first.
Preserve correct handling of mark events, start/end events, orphan cases, and span or trajectory fields derived from intended event data.
Run affected Rust tests and just test-rust when event fields change; run just test-python, just test-go, and just test-node when binding-native configuration or lifecycle changes.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

**/*.{rs,py,js,ts,tsx,go,java,kt,swift}

📄 CodeRabbit inference engine (.agents/skills/add-middleware/SKILL.md)

Add tests covering registration and duplicate names, deregistration and missing names, priority ordering, callback failure policy, scope-local inheritance and cleanup, event payload semantics, immutable mark and scope fields, and parity across affected bindings.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}

⚙️ CodeRabbit configuration file

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.

Files:

crates/cli/tests/coverage/shared/config_tests.rs

🔇 Additional comments (1)

crates/cli/tests/coverage/shared/config_tests.rs (1)

3797-3797: LGTM!

Walkthrough

Plugin discovery now preserves file values when typed configuration fields use defaults. It validates each discovered document’s version before merging and reports invalid versions with source paths. Tests and fixtures now use supported version-1 configurations.

Changes

Plugin configuration discovery

Layer / File(s)	Summary
Default-aware configuration overlays `crates/core/src/plugin.rs`, `crates/core/tests/unit/plugin_tests.rs`	Discovery overlays omit default-valued `version`, `policy`, and component `enabled` fields. Explicit non-default values still override file values.
Per-file version validation and precedence tests `crates/core/src/plugin.rs`, `crates/core/tests/unit/plugin_tests.rs`, `crates/cli/tests/coverage/shared/config_tests.rs`, `crates/ffi/tests/integration/plugin_activation_tests.rs`, `go/nemo_relay/plugin_activation_test.go`	Configuration documents accept only version `1`. Invalid versions produce path-specific errors before precedence merging. Fixtures and assertions verify override policy data.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant initialize_plugins
  participant resolve_plugin_config
  participant merge_plugin_config_documents
  participant plugin_config_file
  initialize_plugins->>resolve_plugin_config: resolve typed plugin configuration
  resolve_plugin_config->>merge_plugin_config_documents: submit default-filtered overlay
  merge_plugin_config_documents->>plugin_config_file: read discovered TOML document
  merge_plugin_config_documents->>merge_plugin_config_documents: validate version 1
  merge_plugin_config_documents-->>initialize_plugins: return layered configuration or path error

Possibly related PRs

NVIDIA/NeMo-Relay#584: Modifies the same plugin configuration layering and precedence logic in crates/core/src/plugin.rs and its tests.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows Conventional Commits format, uses an allowed type, states the fix clearly, and is under 72 characters.
Description check	✅ Passed	The description includes all required sections, explains the changes and validation, identifies review starting points, and uses a valid related-issue keyword.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/ffi/tests/integration/plugin_activation_tests.rs`:
- Line 125: Update the fixture and assertions around the version-precedence test
so the comments match the actual data: either remove the stale claim that
explicit version 1 overrides discovered version 999, or change the fixture to
use a different explicit version and retain an assertion covering that
precedence behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 2fecab70-0f53-4034-a48b-2eb513b8f6ae

📥 Commits

Reviewing files that changed from the base of the PR and between 783bac7 and e6ce18d.

📒 Files selected for processing (5)

crates/cli/tests/coverage/shared/config_tests.rs
crates/core/src/plugin.rs
crates/core/tests/unit/plugin_tests.rs
crates/ffi/tests/integration/plugin_activation_tests.rs
go/nemo_relay/plugin_activation_test.go

📜 Review details

⏰ Context from checks skipped due to timeout. (2)

GitHub Check: Check / Run
GitHub Check: Preview docs

🧰 Additional context used

📓 Path-based instructions (24)

**/*.rs

📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)

**/*.rs: Any Rust change must run just test-rust
Any Rust change must run cargo fmt --all
Any Rust change must run cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all for all FFI work since it is Rust work
Run just test-rust to validate FFI changes
Run cargo clippy --workspace --all-targets -- -D warnings to enforce strict linting on FFI work

When Rust files changed as part of Go work, also run cargo fmt --all, just test-rust, and cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all when Rust files are changed as part of Node work
Run cargo clippy --workspace --all-targets -- -D warnings when Rust files are changed as part of Node work
Run just test-rust when Rust files are changed as part of Node work

When changing the core Rust runtime or Rust-facing API surface, format Rust code with cargo fmt (rustfmt defaults), keep cargo clippy -- -D warnings clean, and satisfy cargo deny check per deny.toml.

**/*.rs: If any Rust code changed, always run just test-rust.
If any Rust code changed, also run cargo fmt --all.
If any Rust code changed, also run cargo clippy --workspace --all-targets -- -D warnings.
For Rust changes headed for review, run cargo fmt --all and cargo clippy --workspace --all-targets -- -D warnings even if relying on pre-commit.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs

crates/ffi/**

📄 CodeRabbit inference engine (.agents/skills/test-ffi-surface/SKILL.md)

Rebuild the FFI crate in release mode so the shared library and header stay in sync when making changes to crates/ffi

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs

crates/ffi/**/*.rs

📄 CodeRabbit inference engine (.agents/skills/test-go-binding/SKILL.md)

If the change touched crates/ffi, also use test-ffi-surface for validation

Use C FFI export names prefixed with nemo_relay_ in the raw C FFI layer.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs

**/*.{rs,py}

📄 CodeRabbit inference engine (AGENTS.md)

Follow binding naming conventions in Rust and Python: use snake_case.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs

**/*.{rs,py,js,mjs,cjs,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{rs,py,js,mjs,cjs,ts,tsx}: Use Json = serde_json::Value in Rust-facing runtime APIs where the existing code expects JSON payloads.
Use Result<T> with FlowError in core runtime paths, and keep errors explicit and binding-appropriate at the wrapper layer.
Keep async behavior on the existing tokio-based model; bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs

**/*.{rs,py,go,js,ts,c,h}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Use language-appropriate naming conventions: Rust snake_case, C FFI exports prefixed nemo_relay_, Go PascalCase, Node.js camelCase, and Python snake_case.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs
go/nemo_relay/plugin_activation_test.go

**/*.{rs,go,js,ts}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Add the SPDX license header to all Rust, Go, JavaScript, and TypeScript source files using the corresponding // comment form.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs
go/nemo_relay/plugin_activation_test.go

**/*

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

**/*: Format changed files with the language-native formatter before the final lint/test pass.
If dynamic plugin behavior changed, use maintain-dynamic-plugins and include the native SDK, worker protocol, Python SDK, docs, packaging, and Codecov surfaces in the validation plan.
If code changes alter APIs, bindings, commands, paths, packaging behavior, observability/adaptive semantics, or documented best practices, update any dependent maintainer or consumer skills in the same branch.
During iteration, prefer uv run pre-commit run --files <changed files...>.
Before review or handoff, run uv run pre-commit run --all-files.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs
go/nemo_relay/plugin_activation_test.go

**/*.{rs,py,go,js,ts}

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

If a language surface changed, always run that language's test target even when Rust core did not change.

**/*.{rs,py,go,js,ts}: When observability configuration or lifecycle is exposed, keep FFI and Python, Go, and Node.js binding-native config objects and subscriber/exporter methods aligned in logical knobs and semantics.
Require every OpenTelemetry endpoint to have a type and nonblank destination; resolve header_env values at activation and reject missing, blank, or duplicate headers.
Concatenate layered ATOF sink, ATIF storage, and OpenTelemetry endpoint lists with higher-precedence entries first.
Preserve correct handling of mark events, start/end events, orphan cases, and span or trajectory fields derived from intended event data.
Run affected Rust tests and just test-rust when event fields change; run just test-python, just test-go, and just test-node when binding-native configuration or lifecycle changes.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs
go/nemo_relay/plugin_activation_test.go

**/*.{rs,py,js,ts,tsx,go,java,kt,swift}

📄 CodeRabbit inference engine (.agents/skills/add-middleware/SKILL.md)

Add tests covering registration and duplicate names, deregistration and missing names, priority ordering, callback failure policy, scope-local inheritance and cleanup, event payload semantics, immutable mark and scope fields, and parity across affected bindings.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs
go/nemo_relay/plugin_activation_test.go

crates/{python,ffi,node}/**/*

⚙️ CodeRabbit configuration file

crates/{python,ffi,node}/**/*: Treat binding changes as public API changes. Check for parity with the other language bindings, FFI ownership/lifetime safety,
callback error propagation, stable type conversion, and consistent async/stream semantics.
Flag changes that update one binding without corresponding tests or documentation for the same surface elsewhere.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}

⚙️ CodeRabbit configuration file

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.

Files:

crates/ffi/tests/integration/plugin_activation_tests.rs
crates/cli/tests/coverage/shared/config_tests.rs
crates/core/tests/unit/plugin_tests.rs
go/nemo_relay/plugin_activation_test.go

{crates/core,crates/adaptive}/**/*

📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)

Changes to crates/core or crates/adaptive must run the full language matrix

Files:

crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs

crates/core/**/*.rs

📄 CodeRabbit inference engine (.agents/skills/test-go-binding/SKILL.md)

If the change touched crates/core or shared runtime semantics, also use validate-change for broader validation

Files:

crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs

crates/{core,adaptive}/**/*

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

If crates/core or crates/adaptive changed, run the full validation matrix across Rust, Python, Go, and Node.js.

Files:

crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs

crates/{core,adaptive}/**/*.rs

⚙️ CodeRabbit configuration file

crates/{core,adaptive}/**/*.rs: Review the Rust runtime for async correctness, scope isolation, middleware ordering, and event lifecycle regressions.
Pay close attention to task-local/thread-local scope propagation, callback lifetimes, stream finalization, and root_uuid isolation.
Public API changes should preserve existing behavior unless tests and docs show the intended migration path.

Files:

crates/core/tests/unit/plugin_tests.rs
crates/core/src/plugin.rs

{crates/**/src/**/*.rs,python/**/*.py}

📄 CodeRabbit inference engine (.agents/skills/maintain-dynamic-plugins/SKILL.md)

Do not add tests under src; Rust tests belong in crate tests/ trees, and Python SDK tests belong under python/tests.

Files:

crates/core/src/plugin.rs

go/nemo_relay/**/*.go

📄 CodeRabbit inference engine (.agents/skills/test-go-binding/SKILL.md)

go/nemo_relay/**/*.go: Format changed Go packages with cd go/nemo_relay && go fmt ./...
Run Go tests with just test-go to build and test the NeMo Relay Go binding
Use just build-go when you want an explicit build-only pass or need the artifact for other work
Use just ci=true test-go when you need the CI-style coverage and JUnit path
On macOS, set DYLD_LIBRARY_PATH to the ../../target/release directory before running the raw go test command directly

Use PascalCase for public Go APIs.

Files:

go/nemo_relay/plugin_activation_test.go

**/*.go

📄 CodeRabbit inference engine (CONTRIBUTING.md)

When changing the experimental Go binding, format Go code with gofmt and keep go vet ./... passing.

Files:

go/nemo_relay/plugin_activation_test.go

{crates/python/src/py_api/mod.rs,python/nemo_relay/**/*.py,python/nemo_relay/**/*.pyi,go/nemo_relay/**/*.go,crates/node/src/api/**/*.rs}

📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)

Update the language-native bindings for every exposed surface in Python, Go, and Node.js.

Files:

go/nemo_relay/plugin_activation_test.go

{python/nemo_relay/**/*.py,python/nemo_relay/**/*.pyi,go/nemo_relay/**/*.go}

📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)

Update language wrapper helpers such as Python wrapper modules, Python type stubs, and Go shorthand packages when the new behavior belongs in those helper layers.

Files:

go/nemo_relay/plugin_activation_test.go

go/nemo_relay/**

📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)

Keep shared plugin helpers in go/nemo_relay aligned with plugin registration, composition, and lifecycle behavior.

Files:

go/nemo_relay/plugin_activation_test.go

**/*.{md,mdx,py,go,js,ts}

📄 CodeRabbit inference engine (.agents/skills/maintain-observability/SKILL.md)

Examples and documentation must use each exporter's documented flush/deregister order before shutdown.

Files:

go/nemo_relay/plugin_activation_test.go

go/nemo_relay/**/*

⚙️ CodeRabbit configuration file

go/nemo_relay/**/*: Review Go binding changes for cgo memory ownership, race safety, callback cleanup, idiomatic exported APIs, and parity with Rust/FFI behavior.
Any API change should include focused Go tests and consider race-test behavior.

Files:

go/nemo_relay/plugin_activation_test.go

🧠 Learnings (2)

📚 Learning: 2026-07-28T20:07:29.880Z

Learnt from: willkill07
Repo: NVIDIA/NeMo-Relay PR: 571
File: crates/core/src/api/runtime/state.rs:996-1020
Timestamp: 2026-07-28T20:07:29.880Z
Learning: In NeMo Relay (RELAY-509), sanitizer callback failures must be treated as intentional fail-open behavior. When an event/tool (request/response) or LLM (request/response) sanitizer callback fails, the sanitizer chain should retain and publish the last valid event/payload snapshot (rather than dropping/invalidating the data) and log the failure including callback context (e.g., which sanitizer/callback failed and relevant identifiers). Apply this consistently across all sanitizer chains mentioned in the RELAY-509 documentation/migration guide.

Applied to files:

crates/core/src/plugin.rs

📚 Learning: 2026-07-28T20:33:25.156Z

Learnt from: willkill07
Repo: NVIDIA/NeMo-Relay PR: 572
File: go/nemo_relay/adaptive_runtime_test.go:214-238
Timestamp: 2026-07-28T20:33:25.156Z
Learning: When adding/adjusting Go unit tests for `BuildCacheRequestFacts` (request-ID validation and related request parsing), set `CacheRequestFactsInput.Provider` to a valid provider in all tests that are intended to isolate request-ID behavior—because `BuildCacheRequestFacts` does not validate `Provider`. Then add separate test coverage for malformed `AnnotatedRequest` JSON so JSON parsing failures are not conflated with `Provider`-related inputs.

Applied to files:

go/nemo_relay/plugin_activation_test.go

🔇 Additional comments (8)

crates/core/src/plugin.rs (3)

1600-1605: LGTM!

1615-1664: LGTM!

1726-1761: LGTM!

crates/core/tests/unit/plugin_tests.rs (3)

2230-2258: LGTM!

2317-2368: LGTM!

2370-2407: LGTM!

crates/cli/tests/coverage/shared/config_tests.rs (1)

2051-2080: LGTM!

go/nemo_relay/plugin_activation_test.go (1)

626-626: LGTM!

github-actions · 2026-08-01T00:14:56Z

Fern docs preview: https://nvidia-preview-pull-request-626.docs.buildwithfern.com/nemo/relay/dev

mnajafian-nv

LGTM!

Signed-off-by: Will Killian <wkillian@nvidia.com>

willkill07 · 2026-08-01T01:00:25Z

/merge

fix: prevent plugin config masking

e6ce18d

Signed-off-by: Will Killian <wkillian@nvidia.com>

willkill07 requested a review from a team as a code owner August 1, 2026 00:09

github-actions Bot added size:M PR is medium Bug issue describes bug; PR fixes bug lang:go PR changes/introduces Go code lang:rust PR changes/introduces Rust code labels Aug 1, 2026

copy-pr-bot Bot temporarily deployed to fern August 1, 2026 00:09 Inactive

coderabbitai Bot reviewed Aug 1, 2026

View reviewed changes

Comment thread crates/ffi/tests/integration/plugin_activation_tests.rs

willkill07 self-assigned this Aug 1, 2026

willkill07 added this to the 0.7 milestone Aug 1, 2026

mnajafian-nv approved these changes Aug 1, 2026

View reviewed changes

test: remove stale plugin version comment

a363419

Signed-off-by: Will Killian <wkillian@nvidia.com>

copy-pr-bot Bot had a problem deploying to fern August 1, 2026 00:27 Error

Merge branch 'release/0.7' into wkk_fix/plugin-config-layering

60a677b

copy-pr-bot Bot temporarily deployed to fern August 1, 2026 00:29 Inactive

mnajafian-nv approved these changes Aug 1, 2026

View reviewed changes

rapids-bot Bot merged commit 2905c9f into NVIDIA:release/0.7 Aug 1, 2026
79 of 81 checks passed

rapids-bot Bot temporarily deployed to fern August 1, 2026 01:00 Inactive

willkill07 deleted the wkk_fix/plugin-config-layering branch August 4, 2026 00:29

Navigation Menu

Uh oh!

fix: prevent plugin config masking - #626

fix: prevent plugin config masking#626
rapids-bot[bot] merged 3 commits into
NVIDIA:release/0.7from
willkill07:wkk_fix/plugin-config-layering

willkill07 commented Aug 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 1, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

mnajafian-nv left a comment

Uh oh!

willkill07 commented Aug 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

willkill07 commented Aug 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Details

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

mnajafian-nv left a comment

Choose a reason for hiding this comment

Uh oh!

willkill07 commented Aug 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

willkill07 commented Aug 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 1, 2026 •

edited

Loading