Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/cli/tests/coverage/plugins_tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@ fn typed_editor_model_contains_pii_redaction_options() {
&["builtin", "local_model"]
);
assert_eq!(schema.field("codec").unwrap().kind, EditorFieldKind::Enum);
assert_eq!(schema.field("mark").unwrap().kind, EditorFieldKind::Boolean);
assert_eq!(
schema.field("tool_output").unwrap().kind,
EditorFieldKind::Boolean
Expand Down
4 changes: 3 additions & 1 deletion crates/pii-redaction/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ sha2 = "0.11"
schemars = { version = "0.8", optional = true }

[dev-dependencies]
nemo-relay = { workspace = true, features = ["openinference"] }
nemo-relay = { workspace = true, features = ["openinference", "otel"] }
futures = "0.3"
tokio = { version = "1", features = ["rt", "macros", "sync", "test-util", "rt-multi-thread", "time"] }
opentelemetry_sdk = { workspace = true, features = ["trace", "testing"] }
tempfile = "3"
28 changes: 27 additions & 1 deletion crates/pii-redaction/src/builtin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@ use serde::de::DeserializeOwned;
use serde_json::Value as Json;
use sha2::{Digest, Sha256};

use nemo_relay::api::event::{CategoryProfile, Event};
use nemo_relay::api::llm::LlmRequest;
use nemo_relay::api::runtime::{LlmSanitizeRequestFn, LlmSanitizeResponseFn, ToolSanitizeFn};
use nemo_relay::api::runtime::{
EventSanitizeFn, LlmSanitizeRequestFn, LlmSanitizeResponseFn, ToolSanitizeFn,
};
use nemo_relay::codec::anthropic::AnthropicMessagesCodec;
use nemo_relay::codec::openai_chat::OpenAIChatCodec;
use nemo_relay::codec::openai_responses::OpenAIResponsesCodec;
Expand Down Expand Up @@ -256,6 +259,29 @@ pub(super) fn tool_sanitize_callback(backend: CompiledBuiltinBackend) -> ToolSan
Arc::new(move |_name: &str, payload: Json| backend.sanitize_json_preorder_dfs(payload))
}

pub(super) fn event_sanitize_callback(backend: CompiledBuiltinBackend) -> EventSanitizeFn {
Arc::new(move |event, mut fields| {
if matches!(event, Event::Scope(_))
&& event
.category()
.is_some_and(|category| matches!(category.as_str(), "tool" | "llm"))
{
return fields;
}

fields.data = fields
.data
.map(|data| backend.sanitize_json_preorder_dfs(data));
fields.metadata = fields
.metadata
.map(|metadata| backend.sanitize_json_preorder_dfs(metadata));
fields.category_profile = fields.category_profile.and_then(|profile| {
sanitize_serializable_with_backend::<CategoryProfile>(&backend, profile).ok()
});
fields
})
}

pub(super) fn llm_sanitize_request_callback(
backend: CompiledBuiltinBackend,
) -> LlmSanitizeRequestFn {
Expand Down
40 changes: 35 additions & 5 deletions crates/pii-redaction/src/component.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ pub struct PiiRedactionConfig {
/// Whether to sanitize managed LLM response payloads.
#[serde(default = "default_true")]
pub output: bool,
/// Whether to sanitize mark event observability fields.
#[serde(default = "default_true")]
pub mark: bool,
/// Whether to sanitize managed tool request payloads.
#[serde(default = "default_true")]
pub tool_input: bool,
Expand Down Expand Up @@ -112,6 +115,7 @@ impl Default for PiiRedactionConfig {
mode: default_mode(),
input: true,
output: true,
mark: true,
tool_input: true,
tool_output: true,
priority: default_priority(),
Expand Down Expand Up @@ -199,6 +203,7 @@ nemo_relay::editor_config! {
},
input => { label: "input", kind: Boolean },
output => { label: "output", kind: Boolean },
mark => { label: "mark", kind: Boolean },
tool_input => { label: "tool_input", kind: Boolean },
tool_output => { label: "tool_output", kind: Boolean },
priority => { label: "priority", kind: Integer },
Expand Down Expand Up @@ -423,6 +428,7 @@ fn validate_pii_redaction_plugin_config(
"mode",
"input",
"output",
"mark",
"tool_input",
"tool_output",
"priority",
Expand Down Expand Up @@ -497,7 +503,7 @@ fn validate_surface_selection(
policy: &ConfigPolicy,
config: &PiiRedactionConfig,
) {
if config.input || config.output || config.tool_input || config.tool_output {
if config.input || config.output || config.mark || config.tool_input || config.tool_output {
return;
}

Expand Down Expand Up @@ -725,6 +731,14 @@ fn register_builtin_backend(
})?;
let compiled = CompiledBuiltinBackend::new(builtin, config.codec.clone())?;

if config.mark {
ctx.register_mark_sanitize_guardrail(
"mark",
config.priority,
super::builtin::event_sanitize_callback(compiled.clone()),
)?;
}

if config.tool_input {
let sanitizer = tool_sanitize_callback(compiled.clone());
ctx.register_tool_sanitize_request_guardrail("tool_input", config.priority, sanitizer)?;
Expand All @@ -734,12 +748,28 @@ fn register_builtin_backend(
ctx.register_tool_sanitize_response_guardrail("tool_output", config.priority, sanitizer)?;
}
if config.input {
let sanitizer = llm_sanitize_request_callback(compiled.clone());
ctx.register_llm_sanitize_request_guardrail("input", config.priority, sanitizer)?;
ctx.register_llm_sanitize_request_guardrail(
"input",
Comment thread
bbednarski9 marked this conversation as resolved.
config.priority,
llm_sanitize_request_callback(compiled.clone()),
)?;
ctx.register_scope_sanitize_start_guardrail(
"input",
config.priority,
super::builtin::event_sanitize_callback(compiled.clone()),
)?;
}
if config.output {
let sanitizer = llm_sanitize_response_callback(compiled);
ctx.register_llm_sanitize_response_guardrail("output", config.priority, sanitizer)?;
ctx.register_llm_sanitize_response_guardrail(
"output",
config.priority,
llm_sanitize_response_callback(compiled.clone()),
)?;
ctx.register_scope_sanitize_end_guardrail(
"output",
config.priority,
super::builtin::event_sanitize_callback(compiled),
)?;
}

Ok(())
Expand Down
Loading
Loading