ci: publish Python plugin wheel - #356
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (16).gitlab-ci.yml📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
{.github/**,.gitlab-ci.yml,.pre-commit-config.yaml,justfile,scripts/**}⚙️ CodeRabbit configuration file
Files:
.github/workflows/*.{yml,yaml}📄 CodeRabbit inference engine (.agents/skills/maintain-ci/SKILL.md)
Files:
.github/**/*.{yml,yaml}📄 CodeRabbit inference engine (.agents/skills/maintain-dynamic-plugins/SKILL.md)
Files:
.github/workflows/*.yml📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
**/*.{md,rst,html,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.{md,rst,html}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Files:
**/*.{md,rst,txt}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/*.{md,rst}📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Files:
**/*.md📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-technical-docs.md)
Files:
**/*📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{rs,go,js,ts,py,html,md,mdx,toml,yml,yaml,c,h}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*.{md,mdx}📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
RELEASING.md📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (3)📚 Learning: 2026-04-15T18:16:52.951ZApplied to files:
📚 Learning: 2026-05-01T13:41:07.485ZApplied to files:
📚 Learning: 2026-05-03T04:23:07.497ZApplied to files:
🔇 Additional comments (4)
WalkthroughThis PR renames the plugin SDK wheel artifact from ChangesPlugin wheel artifact renaming and propagation
Estimated code review effort: 1 (Trivial) | ~5 minutes Sequence Diagram(s)sequenceDiagram
participant CIPython as ci_python.yml Package job
participant CIYaml as ci.yaml publish-python job
participant GitLabCI as .gitlab-ci.yml collect job
participant PyPI
CIPython->>CIPython: Upload artifact as "plugin-wheel"
CIYaml->>CIPython: Download "plugin-wheel" into dist/
CIYaml->>PyPI: Publish wheels from dist/
GitLabCI->>CIPython: Download "plugin-wheel" into downloaded/wheels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/merge |
Overview
Make the
nemo-relay-pluginPython wheel an explicit release artifact so tag releases publish it to PyPI alongsidenemo-relay.Details
plugin-wheelso it is not hidden by the general platform-wheel glob.nemo-relay-pluginas a published PyPI surface.Where should the reviewer start?
Start with
.github/workflows/ci.yaml, where the release job explicitly downloads the plugin wheel before invoking trusted PyPI publishing.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Documentation