fix!: drop Cursor support - #333
Conversation
Signed-off-by: Will Killian <wkillian@nvidia.com>
github-actions
Bot
added
size:XL
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (2)
🧰 Additional context used📓 Path-based instructions (10)**/*.rs📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Files:
{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Files:
**/{Cargo.toml,**/*.rs}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
**/*.{h,hpp,c,cpp,rs}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
**/*.{rs,toml}📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Files:
**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{rs,py,go,js,ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
crates/**/*.rs📄 CodeRabbit inference engine (AGENTS.md)
Files:
**⚙️ CodeRabbit configuration file
Files:
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
WalkthroughRemoves Cursor support from the CLI, server routes, installer/launcher logic, setup and doctor flows, tests, and user-facing documentation. Claude Code, Codex, and Hermes remain as the supported agents. ChangesCursor Agent Removal
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/cli/tests/coverage/config_tests.rs (1)
238-298: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winAdd a regression for stale
[agents.cursor]config.Dropping the Cursor table from the happy-path fixture stops testing the breaking-change contract for existing user configs. Please add a dedicated parse test that feeds
[agents.cursor]and asserts the intended outcome explicitly, so this removal cannot silently regress. As per path instructions, tests should cover the behavior promised by the changed API surface.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/cli/tests/coverage/config_tests.rs` around lines 238 - 298, The happy-path TOML mapping test no longer covers the breaking-change behavior for legacy Cursor configs. Add a dedicated regression test in the config tests around resolve_run_config/explicit_toml_config_maps_supported_sections that includes an [agents.cursor] table and asserts the intended result explicitly, so the stale Cursor config contract is still verified independently of the other agents.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/cli/tests/cli_tests.rs`:
- Around line 1175-1181: The CLI help assertions in cli_tests should be paired
with explicit negative coverage for the removed Cursor entry points. Update the
relevant tests around the command parsing assertions to invoke both nemo-relay
cursor and hook-forward cursor and verify they fail/reject rather than just
omitting Cursor from help. Use the existing CLI test helpers and the affected
subcommand symbols to ensure a hidden alias or stale clap value cannot still
pass the suite.
---
Outside diff comments:
In `@crates/cli/tests/coverage/config_tests.rs`:
- Around line 238-298: The happy-path TOML mapping test no longer covers the
breaking-change behavior for legacy Cursor configs. Add a dedicated regression
test in the config tests around
resolve_run_config/explicit_toml_config_maps_supported_sections that includes an
[agents.cursor] table and asserts the intended result explicitly, so the stale
Cursor config contract is still verified independently of the other agents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: d8c6a499-27ba-4f3b-b131-3ff101720382
📒 Files selected for processing (34)
README.mdcrates/cli/README.mdcrates/cli/src/adapters/cursor.rscrates/cli/src/adapters/mod.rscrates/cli/src/config.rscrates/cli/src/doctor.rscrates/cli/src/installer.rscrates/cli/src/launcher.rscrates/cli/src/main.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/src/setup/model.rscrates/cli/tests/cli_tests.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/tests/coverage/installer_tests.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/tests/coverage/server_tests.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/coverage/setup_tests.rsdocs/about-nemo-relay/overview.mdxdocs/getting-started/agent-runtime-primer.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdxdocs/nemo-relay-cli/cursor.mdxintegrations/coding-agents/README.mdintegrations/coding-agents/cursor/.cursor/hooks.jsonintegrations/coding-agents/cursor/README.md
💤 Files with no reviewable changes (9)
- integrations/coding-agents/cursor/.cursor/hooks.json
- integrations/coding-agents/cursor/README.md
- docs/nemo-relay-cli/cursor.mdx
- crates/cli/src/adapters/cursor.rs
- crates/cli/src/main.rs
- crates/cli/src/setup/model.rs
- crates/cli/tests/coverage/installer_tests.rs
- crates/cli/src/doctor.rs
- crates/cli/tests/coverage/server_tests.rs
📜 Review details
🧰 Additional context used
📓 Path-based instructions (32)
{docs/**,README.md,CONTRIBUTING.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
{docs/**,README.md,CONTRIBUTING.md}: For docs-only changes, run targeted checks only if commands, package names, or examples changed. Usejust docsfor docs-site builds andjust docs-linkcheckwhen links changed
Run docs site build withjust docs
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxREADME.mddocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdx
{docs/**,README.md,CONTRIBUTING.md,**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Run docs link validation with
just docs-linkcheckwhen links change
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxcrates/cli/README.mdREADME.mddocs/nemo-relay-cli/about.mdxintegrations/coding-agents/README.mddocs/nemo-relay-cli/basic-usage.mdx
{docs/**,README.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Verify README and docs entry points still match current package names and paths for large or public-facing changes
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxREADME.mddocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdx
{docs/**,examples/**,README.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Verify examples still run with documented commands for large or public-facing changes
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxREADME.mddocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdx
{docs/**,README.md,**/Cargo.toml,**/package.json,**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Ensure renamed public surfaces are reflected consistently in manifests and docs for large or public-facing changes
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxcrates/cli/README.mdREADME.mddocs/nemo-relay-cli/about.mdxintegrations/coding-agents/README.mddocs/nemo-relay-cli/basic-usage.mdx
**/*.{md,mdx,py,sh,yaml,yml,toml,json}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxcrates/cli/README.mdREADME.mddocs/nemo-relay-cli/about.mdxintegrations/coding-agents/README.mddocs/nemo-relay-cli/basic-usage.mdx
**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
In MDX files, top-of-file comments must use JSX comment delimiters: {/* to open and */} to close. Do not use HTML comments for MDX SPDX headers.
MDX top-of-file SPDX comments must use {/* ... */} delimiters instead of HTML comment delimiters (Must-Fix)
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdx
**/*.{html,md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license header in HTML and Markdown files using HTML comment syntax
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxcrates/cli/README.mdREADME.mddocs/nemo-relay-cli/about.mdxintegrations/coding-agents/README.mddocs/nemo-relay-cli/basic-usage.mdx
docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update embedded documentation snippets, patch docs, and binding-support notes if examples or supported bindings changed
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdx
docs/**
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run
just docsor./scripts/build-docs.sh htmlto regenerate ignored Fern API reference pages before validation for documentation site changes
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxdocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdx
**
⚙️ CodeRabbit configuration file
**:AGENTS.md
This file provides guidance to agents, including Claude Code and OpenAI Codex, when working in this repository.
Project Overview
NeMo Relay is a multi-language agent runtime framework for execution scopes, lifecycle events, middleware, plugins, and observability around tool and LLM calls. The core runtime is Rust. Primary supported bindings are Rust, Python, and Node.js. Go, WebAssembly, and the raw C FFI are experimental and source-first.
The shared runtime model is:
- Scope stacks decide where work belongs and which scope-local behavior is visible.
- Middleware registries decide what guardrails and intercepts run around managed calls.
- Plugins install reusable runtime behavior from configuration.
- Events record runtime behavior in ATOF form.
- Subscribers and exporters consume events in-process or export them to ATIF, OpenTelemetry, OpenInference, or other backends.
Repository Structure
The repository layout separates the Rust runtime, language bindings, documentation,
integration patches, and agent-facing skills.crates/ core/ # Rust core runtime crate, published as nemo-relay adaptive/ # Adaptive runtime primitives and plugin components python/ # PyO3 native extension for the Python package ffi/ # Raw C ABI layer used by downstream bindings such as Go node/ # NAPI Node.js binding and JavaScript/TypeScript entry points wasm/ # wasm-bindgen WebAssembly binding and JS wrappers python/ nemo_relay/ # Python wrapper package: scopes, tools, LLM, middleware, typed helpers, plugins, adaptive helpers tests/ # Python tests go/ nemo_relay/ # Experimental Go CGo binding and tests fern/ # Fern documentation site scripts/ # Stable wrappers and helper scripts; build/test/docs entry points live in justfile third_party/ # P...
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxcrates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/README.mdcrates/cli/tests/coverage/plugin_shim_tests.rsREADME.mdcrates/cli/src/adapters/mod.rsdocs/nemo-relay-cli/about.mdxcrates/cli/tests/coverage/session_tests.rsintegrations/coding-agents/README.mdcrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rsdocs/nemo-relay-cli/basic-usage.mdxcrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency across language bindings.
Flag stale examples, missing SPDX headers where required, and instructions that no longer match CI or pre-commit behavior.
Files:
docs/getting-started/agent-runtime-primer.mdxdocs/about-nemo-relay/overview.mdxdocs/getting-started/quick-start/index.mdxdocs/integrate-into-frameworks/about.mdxREADME.mddocs/nemo-relay-cli/about.mdxdocs/nemo-relay-cli/basic-usage.mdx
**/*.rs
📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Use
snake_casenaming convention for Rust identifiers (e.g.,nemo_relay_tool_call)
**/*.rs: Any Rust change must runjust test-rust
Any Rust change must runcargo fmt --all
Any Rust change must runcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allfor all FFI work since it is Rust work
Runjust test-rustto validate FFI changes
Runcargo clippy --workspace --all-targets -- -D warningsto enforce strict linting on FFI workWhen Rust files changed as part of Go work, also run
cargo fmt --all,just test-rust, andcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allwhen Rust files are changed as part of Node work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files are changed as part of Node work
Runjust test-rustwhen Rust files are changed as part of Node work
**/*.rs: Runcargo fmt --allto format all Rust code
Runcargo clippy --workspace --all-targets -- -D warningsto enforce all clippy lints as errors
**/*.rs: Runcargo fmt --allwhen Rust files changed as part of WebAssembly work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files changed as part of WebAssembly work
**/*.rs: If any Rust code changed, always runjust test-rust
If any Rust code changed, also runcargo fmt --all
If any Rust code changed, also runcargo clippy --workspace --all-targets -- -D warnings
Run Rust formatting withcargo fmt --all
Run Rust linting withcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Usecargo fmtfor Rust code formatting
Runcargo clippy -- -D warningsto lint Rust code and treat all warnings as errors
Use Rust snake_case naming convention for Rust identifiers
Include SPDX license header in all Rust source files using double-slash comment syntax
Validate Rust code withuv run pre-commit run --all-filesto enforce cargo fmt formatting check, cargo clippy lints, and cargo deny aud...
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/src/adapters/mod.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Maintain documented and tested validation and report behavior for adaptive surfaces
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/tests/coverage/launcher_tests.rs
**/{Cargo.toml,**/*.rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Maintain consistency between Rust package names in
Cargo.tomland their actual usage across the codebase
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/src/adapters/mod.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
**/*.{h,hpp,c,cpp,rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Ensure FFI header and library naming follows consistent conventions across platform-specific builds
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/src/adapters/mod.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
**/*.{rs,toml}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update Rust crate names and module prefixes during coordinated rename operations
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/src/adapters/mod.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}
📄 CodeRabbit inference engine (AGENTS.md)
Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/README.mdcrates/cli/tests/coverage/plugin_shim_tests.rsREADME.mdcrates/cli/src/adapters/mod.rscrates/cli/tests/coverage/session_tests.rsintegrations/coding-agents/README.mdcrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
**/*.{rs,py,go,js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Follow binding naming conventions: Rust and Python use
snake_case, C FFI exports prefixednemo_relay_, Go usesPascalCasefor public APIs, Node.js usescamelCase.
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/src/adapters/mod.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
crates/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
crates/**/*.rs: Keep async behavior on the existing tokio-based model. Bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.
UseJson = serde_json::Valuein Rust-facing runtime APIs for JSON payload handling.
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/src/adapters/mod.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/src/model.rscrates/cli/src/server.rscrates/cli/src/setup.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/src/installer.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/src/launcher.rscrates/cli/tests/coverage/launcher_tests.rscrates/cli/src/config.rs
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}
⚙️ CodeRabbit configuration file
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.
Files:
crates/cli/tests/coverage/main_tests.rscrates/cli/tests/coverage/setup_tests.rscrates/cli/tests/coverage/plugin_shim_tests.rscrates/cli/tests/coverage/session_tests.rscrates/cli/tests/cli_tests.rscrates/cli/tests/coverage/adapters_tests.rscrates/cli/tests/coverage/config_tests.rscrates/cli/tests/coverage/doctor_tests.rscrates/cli/tests/coverage/launcher_tests.rs
**/*.{md,rst,html,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
**/*.{md,rst,html,txt}: Always spellNVIDIAin all caps. Do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms withs, not an apostrophe, such asGPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such asCPU,GPU,PC,API, andUIusually do not need to be spelled out for developer audiences.
Files:
crates/cli/README.mdREADME.mdintegrations/coding-agents/README.md
**/*.{md,rst,html}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Link the first mention of a product name when the destination helps the reader.
Files:
crates/cli/README.mdREADME.mdintegrations/coding-agents/README.md
**/*.md
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Documentation must be updated if activation or usage changed
**/*.md: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Format code elements, commands, parameters, package names, and expressions in monospace
Format directories, file names, and paths in monospace using backticks
Use angle brackets inside monospace for variables inside paths, such as/home/<username>/.login
Format error messages and strings in quotation marks, keeping literal code strings in code formatting when clearer
Format UI buttons, menus, fields, and labels in bold
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use, sparingly and only when introducing the term
Use italics for publication titles
Format keyboard shortcuts in plain text, such as Press Ctrl+Alt+Delete
Use owner/repo link text for GitHub repositories, preferring[NVIDIA/NeMo](link)over prose references like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text
Avoid generic anchor text such as 'here,' 'this page,' and 'read more'
Include acronyms in link text when a linked term includes an acronym
Do not link long sentences or multiple sentences
Avoid links ...
Files:
crates/cli/README.mdREADME.mdintegrations/coding-agents/README.md
**/{docs,examples,**/*.md,*.patch,*.diff,.github,*.sh,*.yaml,*.yml}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update documentation, examples, CI configuration, and patch artifacts when performing rename operations
Files:
crates/cli/README.mdREADME.mdintegrations/coding-agents/README.md
**/*.{md,rst,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Spell
NVIDIAin all caps. Do not useNvidia,nvidia, orNV.
Files:
crates/cli/README.mdREADME.mdintegrations/coding-agents/README.md
**/*.{md,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,rst}: Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as "here" or "read more."
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical docs.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented docs unless the source, platform, or legal guidance explicitly requires them.
Files:
crates/cli/README.mdREADME.mdintegrations/coding-agents/README.md
**/README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update relevant crate or package README when that surface changed
Files:
crates/cli/README.mdREADME.mdintegrations/coding-agents/README.md
{README.md,docs/getting-started/**/*.md}
📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Update
README.md,docs/getting-started/, or binding-level READMEs if behavior differs by language or usage changed
Files:
README.md
README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update
README.mdto reflect current workspace members and top-level documentation when workspace structure changes
Files:
README.md
{README.md,docs/**/*.{md,rst,txt},fern/**/*}
📄 CodeRabbit inference engine (.agents/skills/prepare-code-freeze/SKILL.md)
Search and update documentation source for references to the old version in
README.md,docs, andferndirectories, updating current-version install commands, package examples, and configuration examples to<next-version>
Files:
README.md
**/*config*.{rs,ts,py,go,js,json,yaml,yml}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Ensure dynamic config shape still matches the documented canonical model
Files:
crates/cli/tests/coverage/config_tests.rscrates/cli/src/config.rs
🔇 Additional comments (22)
crates/cli/src/model.rs (1)
7-12: LGTM!Also applies to: 17-24, 28-50
crates/cli/src/config.rs (1)
522-530: LGTM!Also applies to: 613-617, 657-664, 952-952, 1229-1244, 1362-1368, 1373-1379, 1383-1394
crates/cli/src/adapters/mod.rs (1)
4-5: LGTM!Also applies to: 377-403
crates/cli/src/server.rs (1)
26-26: LGTM!Also applies to: 166-183, 376-389
crates/cli/src/installer.rs (2)
201-208: LGTM!Also applies to: 230-244, 275-281
4-5: 📐 Maintainability & Code QualityNo unused import issue here —
Readis used bystdin().read_to_string(...), andPathis no longer referenced.crates/cli/src/launcher.rs (1)
22-22: LGTM!Also applies to: 228-234, 238-248, 253-261, 263-269, 502-516, 582-613
crates/cli/src/setup.rs (2)
63-63: LGTM!Also applies to: 185-186, 199-235
204-208: 🎯 Functional CorrectnessNo residual Cursor references remain in the CLI crate.
README.md (1)
29-29: LGTM!Also applies to: 282-285
crates/cli/README.md (1)
30-31: LGTM!Also applies to: 46-47
docs/about-nemo-relay/overview.mdx (1)
44-44: LGTM!docs/nemo-relay-cli/basic-usage.mdx (1)
16-16: LGTM!Also applies to: 28-30, 61-62, 74-74, 145-150, 337-345, 374-376
integrations/coding-agents/README.md (1)
33-36: LGTM!Also applies to: 46-52
docs/getting-started/agent-runtime-primer.mdx (1)
112-112: LGTM!docs/getting-started/quick-start/index.mdx (1)
41-41: LGTM!docs/integrate-into-frameworks/about.mdx (1)
53-53: LGTM!docs/nemo-relay-cli/about.mdx (1)
24-25: LGTM!Also applies to: 50-51, 64-65
crates/cli/tests/coverage/launcher_tests.rs (1)
5-5: LGTM!Also applies to: 161-201, 724-757, 760-795
crates/cli/tests/coverage/main_tests.rs (1)
215-215: LGTM!crates/cli/tests/coverage/plugin_shim_tests.rs (1)
2033-2041: LGTM!Also applies to: 2073-2073
crates/cli/tests/coverage/session_tests.rs (1)
3427-3448: LGTM!Also applies to: 4272-4309, 4388-4409
|
Agree that this support should be dropped. I haven't seen a strong case or passionate customers for these features. No need to carry it for now |
mnajafian-nv
left a comment
mnajafian-nv
left a comment
There was a problem hiding this comment.
LGTM overall. The Cursor removal looks clean and consistent end to end. I left one small inline note on the legacy config migration path, but this looks good to merge from my side.
| CodingAgent::infer("cursor-agent"), | ||
| Some(CodingAgent::Cursor) | ||
| ); | ||
| assert_eq!(CodingAgent::infer("cursor-agent"), None); |
There was a problem hiding this comment.
One behavior I’d love to make explicit before this disappears into history is the legacy Cursor config path. We now verify that cursor-agent is no longer inferred, but existing [agents.cursor] config also appears to be ignored silently after this change. A small regression test for the intended stale-config behavior would make the breaking-change contract much clearer for future reviewers.
|
Do we now silently fail on cursor configs? Maybe a deprecation warning would be helpful |
|
@bbednarski9 @mnajafian-nv the current behavior for config files do not specify In
Let me know what you want me to do.
|
Signed-off-by: Will Killian <wkillian@nvidia.com>
#### Overview Establish explicit, shared extraction-strategy boundaries before code is moved onto them: provider schema extraction (codec-owned), agent payload extraction (harness-owned), and exporter projection. This is a refactor — runtime ownership, event shapes, and binding-facing behavior are unchanged. The only public surface added is the additive `normalize_request_with_hint`. This branch has been merged with current `main` after PR #333 removed Cursor support; the agent-side extraction split now covers the supported coding-agent integrations: Claude Code, Codex, and Hermes. - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. #### Details **What changed** Provider schema extraction (`crates/core`): - Renamed the internal codec registry surface to provider-extraction names: `SurfaceDescriptor` → `ProviderSurfaceDescriptor`, `REGISTRY` → `BUILTIN_PROVIDER_SURFACES`, per-codec `SURFACE_DESCRIPTOR` → `PROVIDER_SURFACE`, and the detector fn aliases to `RequestSurfaceDetector` / `ResponseSurfaceDetector`. All remain `pub(crate)`. - Documented `LlmResponseCodec::decode_response` as the provider response-extraction interface (model name, finish reason, tool calls, usage, cost, provider-specific fields, replayable response data). - Added hint-aware request normalization: `normalize_request_with_hint(request, hint)` (the existing `normalize_request` now delegates with `None`). `EventNormalizationExt` threads the managed provider-route event name (e.g. `anthropic.messages`) as the codec hint, so an Anthropic Messages body without a top-level `system` no longer misroutes to the OpenAI Chat codec. The Anthropic detector accepts both `"anthropic"` and `"anthropic.messages"` hints. Agent payload extraction (`crates/cli`): - Added shared low-level JSON-path primitives in `crates/cli/src/json_path.rs`, consumed by both adapter and alignment code (existing names preserved via re-export). - Split agent payload extraction into per-host `AgentPayloadExtractor` implementations for Claude Code, Codex, and Hermes; event construction (`common_*_event`, `classify`) stays shared and takes `&dyn AgentPayloadExtractor`. - Split provider request extraction into per-route `ProviderRequestExtractor` implementations (OpenAI Responses / Chat Completions / Models, Anthropic Messages / Count-Tokens), selected by gateway route. - Compatibility fallbacks (synthetic session IDs, synthetic tool-call IDs, `unknown_tool`, generic subagent ID, `Value::Null`) stay at the adapter/session boundary; extractors return `None` for absent fields. Path/PII fields (cwd, transcript_path, project_dir, user email) are not promoted into shared metadata. Docs: - New "Extraction Strategy Boundaries" section in `docs/about-nemo-relay/concepts/codecs.mdx` documenting the provider / agent / exporter split and fallback semantics for missing, sparse, lossy, and summary-only payloads. **Why** Multiple components pull structured information from heterogeneous agent and provider payloads. Defining the strategy interfaces (and separating agent-payload extraction from provider-schema extraction) up front lets later work migrate the duplicated, best-effort extraction chains onto shared seams without widening the public API. **How it was tested** Latest validation after merging current `main`: - `cargo fmt --all` - `cargo test -p nemo-relay-cli adapters::tests` - `PYO3_PYTHON=/Users/yuchenz/Desktop/Work/Project/NeMo-Flow/.venv/bin/python cargo clippy --workspace --all-targets -- -D warnings` - `just test-rust` - `git diff --check` Additional validation performed earlier on this branch: - `uv run pre-commit run --all-files` — SPDX/fmt/clippy/audit + public-docstring gate. Validation scope for review: - `validate-change` was used to select the required matrix. Because this PR touches `crates/core` event normalization (`EventNormalizationExt` and `normalize_request_with_hint`), pre-merge verification should include the broader runtime/language matrix, not Rust-only coverage: `cargo fmt --all`, `cargo clippy --workspace --all-targets -- -D warnings`, `just test-rust`, `just test-python`, `just test-node`, `just test-go`, and `just test-wasm`. - Docs changes should also be covered by `just docs` before merge. Binding behavior is expected to remain compatible because the core API change is additive, event shapes are unchanged, and renamed codec registry symbols remain `pub(crate)`; the full binding matrix is still the required check set for this `crates/core` change. **Breaking changes** None from this PR. `normalize_request_with_hint` is additive; `normalize_request` keeps its signature and behavior (delegates with no hint). #### Where should the reviewer start? `crates/cli/src/adapters/mod.rs` (the `AgentPayloadExtractor` implementations and the per-agent path tables), then `crates/cli/src/json_path.rs` and the adapter coverage tests, then `crates/cli/src/alignment/mod.rs` (`ProviderRequestExtractor` split), and finally `crates/core/src/codec/resolve.rs` (descriptor rename + hint threading) with `crates/core/src/api/event.rs` for the hint wiring. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) Authors: - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Will Killian (https://github.com/willkill07) - https://github.com/lvojtku URL: #318
3 participants
Overview
Remove Cursor as a supported NeMo Relay coding-agent integration because its inconsistent gateway behavior and limited hook coverage prevent reliable observability.
This is a breaking change for users of the
nemo-relay cursorshortcut,--agent cursor,hook-forward cursor, the/hooks/cursorendpoint, or[agents.cursor]configuration.Details
cursor-agentis not inferred and Cursor is absent from CLI help.Validation:
just test-rustcargo fmt --allcargo clippy --workspace --all-targets -- -D warningscargo test -p nemo-relay-cliafter rebasing onto currentmainjust docsuv run pre-commit run --all-filesWhere should the reviewer start?
Start with
crates/cli/src/config.rsfor the supported-agent surface, thencrates/cli/src/server.rsandcrates/cli/src/launcher.rsfor removal of the runtime hook and launch paths.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit