Add --cuda_graph_trace flag to the generated nsys ccommand #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thomasdhc could you review |
|
@thomasdhc could you sign off ci for this PR |
|
Could you address the code style, let's merge it in after |
Signed-off-by: Guyue Huang <[email protected]>
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--cuda-graph-trace=nodeas an argument of the generated nsys profile command. When the workload is not using cuda graph, this flag has no impact on workload. When the workload uses cuda graph, this flag gives nsys the visibility of kernels within a cuda graph.