-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Support MCP Authentication #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
80 commits
Select commit
Hold shift + click to select a range
f28adf3
Remove the call to _clear_tool_defs_cache (doesn't appear to be neede…
dagardner-nv 793e2fe
Use to_thread instead
dagardner-nv af52bf6
Bump minimum version of hermes-agent
dagardner-nv e8518ee
Update claude, codex and deepagents to handle args and env
dagardner-nv bc7a137
Update tests
dagardner-nv 65c8ec9
Add E2E tests
dagardner-nv 7bdd1c9
Ensure values for MCP transport
dagardner-nv ad66d64
Allow setting custom http headers for MCP
dagardner-nv 080874f
First pass at auth
dagardner-nv da50ceb
Move the shutdown_mcp_servers call to a thread
dagardner-nv 68fb796
Map the MCP Auth class into Python
dagardner-nv d46197f
Support MCP auth in adapters
dagardner-nv a4a805d
Consolidate common MCP Auth code
dagardner-nv 3fa778c
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-mcp-i…
dagardner-nv 7d0e008
Remove shlex parsing
dagardner-nv 36b23d9
Update add_mcp_server call
dagardner-nv ea2204f
Remove unused imports
dagardner-nv 11d631c
Update tests and readme to match command handling
dagardner-nv 001bcf4
Merge branch 'david-mcp-improvements' into david-mcp-auth
dagardner-nv af48f4b
Merge branch 'david-mcp-improvements' of github.com:dagardner-nv/nemo…
dagardner-nv 9db4ae3
Update docs
dagardner-nv b77756a
NAT informed MCP auth improvements
dagardner-nv c0f6f6b
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-mcp-i…
dagardner-nv 2558adb
Merge branch 'david-mcp-improvements' of github.com:dagardner-nv/nemo…
dagardner-nv 556d4e5
Cleanups
dagardner-nv 8faaec5
Fix handling of localhost and 127.0.0.1
dagardner-nv 58e3dfe
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-mcp-auth
dagardner-nv 2b9a15e
Update schema
dagardner-nv 1e9552f
Resolve dependency conflict
dagardner-nv b8c49c6
Update api docs
dagardner-nv bbe79c8
Update tests
dagardner-nv c4eefaa
Remove validate_stdio_options as it is unneeded
dagardner-nv b241a2b
Fix windows spexific test error
dagardner-nv c27c2fb
WIP
dagardner-nv e193684
Ensure stdio auth isn't leaked
dagardner-nv 556486a
Avoid out of date terminology
dagardner-nv fa808b5
fix: replace claude mcp login subprocess with in-process HTTP/SSE OAu…
dagardner-nv b10a71f
Use McpTransport for the McpServerPlan.transport field
dagardner-nv 32b6e14
Validate the MCP transport field
dagardner-nv 32fc0e6
Fix auth for claude
dagardner-nv 70f4ab3
Update test
dagardner-nv d856e12
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-mcp-auth
dagardner-nv 669e389
Cleanup normalize_custom_headers
dagardner-nv c850c05
Fix merge error
dagardner-nv d16d5e3
Clip the oath timeout to the invokation timeout
dagardner-nv 551d334
Ensure callbacks are closed in stop method
dagardner-nv d3585dc
wrap mcp related blocking calls in asyncio.to_thread to avoid blockin…
dagardner-nv 1541f5c
set deny_unknown_fields
dagardner-nv d8b614f
Track auth on a per-mcp basis
dagardner-nv 7c934a2
Track the timeout
dagardner-nv fa730b6
Ensure custom_headers in the Rust models is reflected in the Python m…
dagardner-nv 72b08b7
Fix credential serialization
dagardner-nv 55454ac
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-mcp-auth
dagardner-nv 7192332
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-mcp-auth
dagardner-nv 327c675
Fix merge error
dagardner-nv 025213a
Merge branch 'main' of github.com:NVIDIA/NeMo-Fabric into david-mcp-auth
dagardner-nv 087235e
First pass at only supporting oauth in the two adapters that support it
dagardner-nv 1abaf94
Move the remaining code in mcp_auth.py into utils.py
dagardner-nv 5a94add
Remove un-needed changes
dagardner-nv 8effc0c
Remove un-needed changes
dagardner-nv a304b0e
Improve http header validation
dagardner-nv 4505120
Fix cursor pagination issue per CR feedback
dagardner-nv 812f9ef
Addressing CR feedback
dagardner-nv 612c136
Update adapters/hermes/src/nemo_fabric_adapters/hermes/configuration.py
dagardner-nv 61a5db9
Allow timeout to be configured
dagardner-nv 01de7c1
Add an as_str method to mcp transport class
dagardner-nv 8c149af
Fix comment
dagardner-nv 3a7baaf
Add just recipe for building schemas
dagardner-nv 144ca53
Update documentation/skills to include the just recipe
dagardner-nv 46d03ff
Update docs
dagardner-nv 76e1e0e
Require authorization_timeout_seconds>0
dagardner-nv 9aaf4b1
Distinguish between timeout errors
dagardner-nv a9d0660
Include mcp server name and header name in error messages
dagardner-nv dda5ff6
Just use just
dagardner-nv 86b29c7
Remove header variable expansion in adapters
dagardner-nv 5d689ac
Fix claude environment variable handling
dagardner-nv 3ea57cb
Catch any exception raised from validate_http_headers
dagardner-nv f2dbad0
Only use McpServerConfig.env for stdio
dagardner-nv 6e1fe61
Document MCP auth
dagardner-nv b68a3a4
Forbid extras in McpAuthenticationConfig
dagardner-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.