Forward-merge release/0.1 into main - #128
Merged
Merged
Conversation
#### Overview Standardize standalone product-name references from “Fabric” to “NeMo Fabric” only where end users can encounter them. Internal implementation comments, private/internal-only docstrings, maintainer guidance, and build-script status text remain unchanged. Preserve `Fabric` where it is the public Python class or another code identifier. #### Details - Audited all tracked repository entries for standalone product-name usage. - Updated public Python SDK docstrings and public Rust documentation comments that feed the API reference and JSON Schema descriptions. - Regenerated the committed Python API reference, Rust API reference, and JSON Schema snapshots. - Updated user-visible CLI help, surfaced adapter and Harbor validation messages, the exported Harbor `FabricAgent` documentation, task metadata, and rendered SVG accessibility text. - Merged `release/0.1`, preserved its adapter-discovery and streaming changes, and updated the user-facing streaming terminology introduced on that branch. - Left regular implementation comments and internal-only docstrings unchanged. - Kept API symbols, imports, calls such as `Fabric.run(...)`, repository URLs, paths, package/crate names, and the lowercase `fabric` CLI unchanged. - Breaking changes: none. #### Validation - `cargo run -p nemo-fabric-core --example generate-schemas -- schemas` - `just docs` (passed; Fern reported the expected warning that the missing-redirects check was skipped without authentication) - `just test-rust` (41 tests passed, plus doc tests) - `just build-python` - `cargo check -p fabric-python --locked` - Focused adapter, Harbor, SDK-contract, and streaming tests (274 passed) - `just test-python` (468 passed, 44 skipped) - `cargo fmt --all -- --check` - `uvx --from ruff==0.15.21 ruff check <changed Python files>` - `bash -n examples/harbor/prepare_swebench.sh scripts/generate_api_docs.sh` - `just --fmt --check` - `git diff --check` #### Where should the reviewer start? Start with `crates/fabric-core/src/config.rs` and `python/src/nemo_fabric/models.py` for the public source-of-truth wording, then review the generated schema and API-reference diffs. The merge commit preserves the newer `release/0.1` implementation while applying the same terminology to its public streaming surfaces. #### Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to) - Relates to: none - [x] I confirm this contribution is my own work, or I have the right to submit it under this project's license. - [x] I searched existing issues and open pull requests, and this does not duplicate existing work. ## Summary by CodeRabbit * **Documentation** * Standardized user-facing terminology from “Fabric” to “NeMo Fabric” across CLI help, SDK/reference docs, generated API pages, JSON schemas, and other reference materials. * **Bug Fixes** * Updated validation, compatibility, and runtime/warning/help messages to consistently reference “NeMo Fabric”. * Refreshed some human-readable reasoning/origin text to match the revised “NeMo Fabric” wording. * **Tests** * Updated assertions to match the revised “NeMo Fabric” text in messages and schema metadata. Authors: - Zhongxuan (Daniel) Wang (https://github.com/zhongxuanwang-nv) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #112
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/0.1 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.