Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure query-planning is disabled for now #97

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

rjzamora
Copy link
Contributor

@rjzamora rjzamora commented Jun 3, 2024

As far as I can tell, the existing logic used to disable query-planning isn't really doing anything. As soon as dask.dataframe is imported, changing the "dataframe.query-planning" configuration will no longer have an effect.

Signed-off-by: rjzamora <rzamora217@gmail.com>
Comment on lines +15 to +26
import dask

# Disable query planning before any tests are loaded
# https://github.com/NVIDIA/NeMo-Curator/issues/73
if dask.config.get("dataframe.query-planning") is True:
raise NotImplementedError(
"NeMo Curator does not support query planning yet. "
"Please disable query planning before importing "
"`nemo_curator`, `dask.dataframe` or `dask_cudf`."
)
else:
dask.config.set({"dataframe.query-planning": False})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we could also just import nemo_curator here as well.

Copy link
Collaborator

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I've run into similar issues when running tests.
@rjzamora Is this good to merge, or do you want to update?

@rjzamora rjzamora marked this pull request as ready for review June 6, 2024 18:09
@rjzamora
Copy link
Contributor Author

rjzamora commented Jun 6, 2024

Is this good to merge, or do you want to update?

Current version of the PR should be fine, but happy to make revisions if requested :)

@ayushdg ayushdg merged commit 4f851da into NVIDIA:main Jun 6, 2024
2 checks passed
@rjzamora rjzamora deleted the query-planning branch June 6, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants