Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #93

Merged
merged 1 commit into from
May 31, 2024
Merged

Update readme #93

merged 1 commit into from
May 31, 2024

Conversation

ayushdg
Copy link
Collaborator

@ayushdg ayushdg commented May 30, 2024

Description

All the changes here are from #62 and the work is done by @jgerh. Just creating a new PR to fix the commit signing and style issues

Usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Co-authored-by: Jennifer Gerhold <[email protected]>
Signed-off-by: Ayush Dattagupta <[email protected]>
@ayushdg ayushdg requested a review from Maghoumi May 30, 2024 22:40
@ayushdg
Copy link
Collaborator Author

ayushdg commented May 30, 2024

@Maghoumi This contains the same changes as #62, but I've opened a new PR to fix the style checks and commit signing issues from the previous one. Just wanted to confirm you're okay with this before I proceed to merge.

Copy link
Collaborator

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maghoumi
Copy link
Collaborator

@ayushdg Thanks for letting me know, LGTM!

@ayushdg ayushdg merged commit e814736 into NVIDIA:main May 31, 2024
3 checks passed
@ayushdg ayushdg deleted the update-readme branch June 3, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants