Global cache_dir variable for exact, fuzzy, and semantic deduplication
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
sarahyurick
changed the title
cache_dir variable for exact, fuzzy, and semantic deduplication
sarahyurick
commented
Nov 20, 2024
Comment on lines
+154
to
+160
| You also need to set a global variable representing the cache directory where the outputs are written: | ||
|
|
||
| .. code-block:: python | ||
|
|
||
| from nemo_curator.cache import initialize_cache_directory | ||
|
|
||
| initialize_cache_directory("cache_dir") |
There was a problem hiding this comment.
Could also make more sense to call this something else, like deduplication_outputs.
| id_column=id_column, | ||
| id_column_type=id_column_type, | ||
| which_to_keep=config.which_to_keep, | ||
| output_dir=os.path.join(cache_dir, config.clustering_save_loc), |
There was a problem hiding this comment.
Might want to re-add output_dir to SemanticClusterLevelDedup and/or add it as a parameter for SemDedup
| self.sorted_clusters_dir = os.path.join( | ||
| get_cache_directory(), "clustering", "sorted" | ||
| ) | ||
| self.output_dir = os.path.join(get_cache_directory(), "clustering") |
There was a problem hiding this comment.
Suggested change
| self.output_dir = os.path.join(get_cache_directory(), "clustering") | |
| self.output_dir = os.path.join(get_cache_directory(), "duplicates") |
?
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Signed-off-by: Sarah Yurick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: