Add support for finetune guard classifier #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
VibhuJawa
changed the title
Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
VibhuJawa
commented
Nov 18, 2024
sarahyurick
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Added a few typo fixes but looks good so far!
When you get a chance can you add it to the examples/ and nemo_curator/scripts/ folders? And to the documentation? You should be able to reference #361 which has all the files that should be created/updated.
Co-authored-by: Sarah Yurick <[email protected]> Signed-off-by: Vibhu Jawa <[email protected]>
Signed-off-by: Vibhu Jawa <[email protected]>
We can do that as a followup, as that is documentation related. Lets get this in first. |
sarahyurick
requested changes
Nov 27, 2024
Signed-off-by: Sarah Yurick <[email protected]>
sarahyurick
approved these changes
Nov 27, 2024
sarahyurick
added a commit
to sarahyurick/NeMo-Curator
that referenced
this pull request
Nov 27, 2024
Signed-off-by: Sarah Yurick <[email protected]>
|
Some of these commits are not signed, so re-opening it as #397. |
sarahyurick
added a commit
that referenced
this pull request
Nov 27, 2024
* add changes from #325 Signed-off-by: Sarah Yurick <[email protected]> * edit state_dict read Signed-off-by: Sarah Yurick <[email protected]> --------- Signed-off-by: Sarah Yurick <[email protected]>
ruchaa-apte
pushed a commit
to ruchaa-apte/NeMo-Curator
that referenced
this pull request
Dec 13, 2024
* add changes from NVIDIA#325 Signed-off-by: Sarah Yurick <[email protected]> * edit state_dict read Signed-off-by: Sarah Yurick <[email protected]> --------- Signed-off-by: Sarah Yurick <[email protected]> Signed-off-by: Rucha Apte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for FineTuneGuard Model