Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix SemDedup bugs #151

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

VibhuJawa
Copy link
Collaborator

Description

Fix SemDedup bugs

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

@VibhuJawa VibhuJawa marked this pull request as ready for review July 12, 2024 20:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@faywang123
Copy link

faywang123 commented Jul 12, 2024

Look good to me, too.

Copy link
Collaborator

@ryantwolf ryantwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryantwolf ryantwolf merged commit 7e69687 into NVIDIA:main Jul 12, 2024
3 checks passed
sarahyurick pushed a commit to sarahyurick/NeMo-Curator that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants